vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-08 12:30:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Delay VST2 editor window sizing

Browse Source 
To work around a buggy plugin.
This commit is contained in:
Robbert van der Helm
2022-02-27 00:59:50 +01:00
parent 136ae5ba98
commit f298a8ae2b
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst2.cpp
+14 -9
View File
@@ -730,19 +730,24 @@ intptr_t Vst2Bridge::dispatch_wrapper(AEffect* plugin,
plugin->dispatcher(plugin, effEditIdle, 0, 0, nullptr, 0.0);
});
// Make sure the wrapper window has the correct initial size. The
// plugin can later change this size using `audioMasterSizeWindow`.
VstRect* editor_rect = nullptr;
plugin->dispatcher(plugin, effEditGetRect, 0, 0, &editor_rect, 0.0);
if (editor_rect) {
editor_->resize(editor_rect->right - editor_rect->left,
editor_rect->bottom - editor_rect->top);
}
const intptr_t result =
plugin->dispatcher(plugin, opcode, index, value,
editor_instance.get_win32_handle(), option);
// Make sure the wrapper window has the correct initial size. The
// plugin can later change this size using `audioMasterSizeWindow`.
// NOTE: Every single plugin handles `effEditGetRect` before
// `effEditOpen` fine. Except for this one single plugin:
// https://codefn42.com/randarp/index.html
VstRect* editor_rect = nullptr;
plugin->dispatcher(plugin, effEditGetRect, 0, 0, &editor_rect, 0.0);
if (editor_rect) {
std::cerr << editor_rect->right << std::endl;
std::cerr << editor_rect->bottom << std::endl;
editor_->resize(editor_rect->right - editor_rect->left,
editor_rect->bottom - editor_rect->top);
}
// NOTE: There's zero reason why the window couldn't already be
// visible from the start, but Waves V13 VST3 plugins think it
// would be a splendid idea to randomly dereference null