vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-06-15 07:53:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid IAudioProcessor::isActive() on GUI thread

Browse Source 
I haven't seen this cause any issues this way, and I could imagine that
this could cause some hangs when initializing a second instance of a
plugin while you're interacting with the GUI of the first instance.
This commit is contained in:
Robbert van der Helm
2021-04-29 14:29:15 +02:00
parent a56e4b337f
commit e4177f2856
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst3.cpp
+1 -4
View File
@@ -1303,10 +1303,7 @@ size_t Vst3Bridge::register_object_instance(
// handled from the same thread to prevent // handled from the same thread to prevent
// deadlocks caused by mutually recursive function // deadlocks caused by mutually recursive function
// calls. // calls.
// TODO: Check if this causes any issues when activating return do_mutual_recursion_on_off_thread<tresult>(
// plugins while simultaneously resizing another
// instance of the same plugin
return do_mutual_recursion_on_gui_thread<tresult>(
[&]() { [&]() {
return object_instances[request.instance_id] return object_instances[request.instance_id]
.component->setActive(request.state); .component->setActive(request.state);