Rename YaHostApplication implementation

The context should make it obvious where it's implemented, and with the
current design we only an implementation on one of the two sides.
This commit is contained in:
Robbert van der Helm
2020-12-18 20:43:43 +01:00
parent d2585a3550
commit d99f880277
7 changed files with 41 additions and 31 deletions
@@ -18,7 +18,7 @@
#include <iostream>
YaHostApplicationHostImpl::YaHostApplicationHostImpl(
YaHostApplicationImpl::YaHostApplicationImpl(
Vst3Bridge& bridge,
YaHostApplication::ConstructArgs&& args)
: YaHostApplication(std::move(args)), bridge(bridge) {
@@ -27,8 +27,9 @@ YaHostApplicationHostImpl::YaHostApplicationHostImpl(
}
tresult PLUGIN_API
YaHostApplicationHostImpl::queryInterface(const Steinberg::TUID _iid,
void** obj) {
YaHostApplicationImpl::queryInterface(const Steinberg::TUID _iid, void** obj) {
// I don't think it's expected of a host to implement multiple interfaces on
// this object, so if we do get a call here it's important that it's logged
// TODO: Successful queries should also be logged
const tresult result = YaHostApplication::queryInterface(_iid, obj);
if (result != Steinberg::kResultOk) {
@@ -39,10 +40,9 @@ YaHostApplicationHostImpl::queryInterface(const Steinberg::TUID _iid,
return result;
}
tresult PLUGIN_API
YaHostApplicationHostImpl::createInstance(Steinberg::TUID cid,
Steinberg::TUID _iid,
void** obj) {
tresult PLUGIN_API YaHostApplicationImpl::createInstance(Steinberg::TUID cid,
Steinberg::TUID _iid,
void** obj) {
// TODO: Implement
std::cerr << "TODO: IHostApplication::createInstance()" << std::endl;
return Steinberg::kNotImplemented;
@@ -20,9 +20,9 @@
#include "../vst3.h"
class YaHostApplicationHostImpl : public YaHostApplication {
class YaHostApplicationImpl : public YaHostApplication {
public:
YaHostApplicationHostImpl(Vst3Bridge& bridge,
YaHostApplicationImpl(Vst3Bridge& bridge,
YaHostApplication::ConstructArgs&& args);
/**
+4 -3
View File
@@ -298,14 +298,15 @@ void Vst3Bridge::run() {
// If we got passed a host context, we'll create a proxy object
// and pass that to the initialize function. This object should
// be cleaned up again during `Vst3PluginProxy::Destruct`.
// TODO: This needs changing when we get to `Vst3HostProxy`
// TODO: This needs changing if it turns out we need a
// `Vst3HostProxy`
// TODO: Does this have to be run from the UI thread? Figure out
// if it does
Steinberg::FUnknown* context = nullptr;
if (request.host_application_context_args) {
object_instances[request.instance_id]
.hsot_application_context =
Steinberg::owned(new YaHostApplicationHostImpl(
Steinberg::owned(new YaHostApplicationImpl(
*this,
std::move(*request.host_application_context_args)));
context = object_instances[request.instance_id]
@@ -328,7 +329,7 @@ void Vst3Bridge::run() {
[&](YaPluginFactory::SetHostContext& request)
-> YaPluginFactory::SetHostContext::Response {
plugin_factory_host_application_context =
Steinberg::owned(new YaHostApplicationHostImpl(
Steinberg::owned(new YaHostApplicationImpl(
*this,
std::move(request.host_application_context_args)));