From d7dc0529a870386ca05b610f1b4aba0f7b6750bc Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Sun, 11 Jul 2021 17:18:45 +0200
Subject: [PATCH] URL encode paths in desktop notifications

---
 src/plugin/utils.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/plugin/utils.cpp b/src/plugin/utils.cpp
index fa180366..7fb7d1b3 100644
--- a/src/plugin/utils.cpp
+++ b/src/plugin/utils.cpp
@@ -416,13 +416,13 @@ bool send_notification(const std::string& title,
     if (append_origin) {
         try {
             const fs::path this_library = get_this_file_location();
-            formatted_body
-                << "\n"
-                << "Source: <a href=\"file://"
-                // TODO: This should be URL encoded, but let's just pray that
-                //       noone uses double quotes in their plugin names
-                << this_library.parent_path().string() << "\">"
-                << xml_escape(this_library.filename().string()) << "</a>";
+            formatted_body << "\n"
+                           << "Source: <a href=\"file://"
+                           << url_encode_path(
+                                  this_library.parent_path().string())
+                           << "\">"
+                           << xml_escape(this_library.filename().string())
+                           << "</a>";
         } catch (const boost::system::system_error&) {
             // I don't think this can fail in the way we're using it, but the
             // last thing we want is our notification informing the user of an