vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-06-12 23:32:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove cache_time_info and always cache time info

Browse Source 
It sort of goes against yabridge's principles to not do these
unnecessary `audioMasterGetTime()` calls if the plugin does that, but it
also hurts the user experience to not have this as a default.
This commit is contained in:
Robbert van der Helm
2021-01-30 00:20:35 +01:00
parent f5b4a28bd0
commit cfb171c991
7 changed files with 29 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst2.cpp
+7 -10
View File
@@ -178,9 +178,7 @@ Vst2Bridge::Vst2Bridge(MainContext& main_context,
// value returned by this function during an audio
// processing cycle will be reused for the rest of the
// cycle.
if (config.cache_time_info) {
time_info.reset();
}
cached_time_info.reset();
// Since the host should only be calling one of `process()`,
// processReplacing()` or `processDoubleReplacing()`, we can all
@@ -548,15 +546,14 @@ intptr_t Vst2Bridge::host_callback(AEffect* effect,
void* data,
float option) {
// HACK: Workaround for a bug in SWAM Cello where it would call
// `audioMasterGetTime()` once for every sample. When this option is
// enabled `time_info` should be reset in the process function. The
// `time_info` value is assigned inside of
// `HostCallbackDataConverter::write()`.
if (config.cache_time_info && time_info) {
return reinterpret_cast<intptr_t>(&*time_info);
// `audioMasterGetTime()` once for every sample. The `time_info` value
// is assigned inside of `HostCallbackDataConverter::write()`. At the
// beginning of the processing cycle this value will be reset.
if (cached_time_info) {
return reinterpret_cast<intptr_t>(&*cached_time_info);
}
HostCallbackDataConverter converter(effect, time_info);
HostCallbackDataConverter converter(effect, cached_time_info);
return sockets.vst_host_callback.send_event(converter, std::nullopt, opcode,
index, value, data, option);
}