Rename YaComponent::Arguments to CreateArgs

This commit is contained in:
Robbert van der Helm
2020-12-11 22:43:12 +01:00
parent d1d85711f0
commit cdb9dae2df
8 changed files with 17 additions and 17 deletions
+3 -3
View File
@@ -16,9 +16,9 @@
#include "component.h"
YaComponent::Arguments::Arguments() {}
YaComponent::CreateArgs::CreateArgs() {}
YaComponent::Arguments::Arguments(
YaComponent::CreateArgs::CreateArgs(
Steinberg::IPtr<Steinberg::Vst::IComponent> component,
size_t instance_id)
: instance_id(instance_id) {
@@ -29,7 +29,7 @@ YaComponent::Arguments::Arguments(
}
}
YaComponent::YaComponent(const Arguments&& args) : arguments(std::move(args)) {
YaComponent::YaComponent(const CreateArgs&& args) : arguments(std::move(args)) {
FUNKNOWN_CTOR
// Everything else is handled directly through callbacks to minimize the
+8 -8
View File
@@ -47,14 +47,14 @@ class YaComponent : public Steinberg::Vst::IComponent {
/**
* These are the arguments for creating a `YaComponentPluginImpl`.
*/
struct Arguments {
Arguments();
struct CreateArgs {
CreateArgs();
/**
* Read arguments from an existing implementation.
*/
Arguments(Steinberg::IPtr<Steinberg::Vst::IComponent> component,
size_t isntance_id);
CreateArgs(Steinberg::IPtr<Steinberg::Vst::IComponent> component,
size_t isntance_id);
/**
* The unique identifier for this specific instance.
@@ -83,7 +83,7 @@ class YaComponent : public Steinberg::Vst::IComponent {
*/
struct Create {
// TODO: Create a `native_tvalue` wrapper, and then also add them here
using Response = std::optional<Arguments>;
using Response = std::optional<CreateArgs>;
ArrayUID cid;
@@ -97,7 +97,7 @@ class YaComponent : public Steinberg::Vst::IComponent {
* Instantiate this instance with arguments read from another interface
* implementation.
*/
YaComponent(const Arguments&& args);
YaComponent(const CreateArgs&& args);
/**
* @remark The plugin side implementation should send a control message to
@@ -137,14 +137,14 @@ class YaComponent : public Steinberg::Vst::IComponent {
getState(Steinberg::IBStream* state) override = 0;
private:
Arguments arguments;
CreateArgs arguments;
// TODO: As explained in a few other places, `YaComponent` objects should be
// assigned a unique ID for identification
};
template <typename S>
void serialize(S& s, std::optional<YaComponent::Arguments>& args) {
void serialize(S& s, std::optional<YaComponent::CreateArgs>& args) {
s.ext(args, bitsery::ext::StdOptional{});
}