vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the DefaultDataConverter method names

Browse Source
This commit is contained in:
Robbert van der Helm
2021-05-20 14:36:07 +02:00
parent 06bae784a8
commit ccfda51a69
4 changed files with 38 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin/bridges/vst2.cpp
+12 -11
View File
@@ -190,10 +190,10 @@ class DispatchDataConverter : public DefaultDataConverter {
VstRect& editor_rectangle) noexcept
: chunk(chunk_data), plugin(plugin), rect(editor_rectangle) {}
EventPayload read(const int opcode,
const int index,
const intptr_t value,
const void* data) const override {
EventPayload read_data(const int opcode,
const int index,
const intptr_t value,
const void* data) const override {
// There are some events that need specific structs that we can't simply
// serialize as a string because they might contain null bytes
switch (opcode) {
@@ -243,8 +243,8 @@ class DispatchDataConverter : public DefaultDataConverter {
return static_cast<native_size_t>(
reinterpret_cast<size_t>(data));
} else {
return DefaultDataConverter::read(opcode, index, value,
data);
return DefaultDataConverter::read_data(opcode, index, value,
data);
}
break;
case effGetParameterProperties:
@@ -301,7 +301,8 @@ class DispatchDataConverter : public DefaultDataConverter {
case effStopProcess:
return nullptr;
default:
return DefaultDataConverter::read(opcode, index, value, data);
return DefaultDataConverter::read_data(opcode, index, value,
data);
break;
}
}
@@ -327,9 +328,9 @@ class DispatchDataConverter : public DefaultDataConverter {
}
}
void write(const int opcode,
void* data,
const EventResult& response) const override {
void write_data(const int opcode,
void* data,
const EventResult& response) const override {
switch (opcode) {
case effOpen: {
// Update our `AEffect` object one last time for improperly
@@ -405,7 +406,7 @@ class DispatchDataConverter : public DefaultDataConverter {
reinterpret_cast<uint8_t*>(output));
} break;
default:
DefaultDataConverter::write(opcode, data, response);
DefaultDataConverter::write_data(opcode, data, response);
break;
}
}