Get rid of old todos

This commit is contained in:
Robbert van der Helm
2020-03-11 14:32:47 +01:00
parent 6fd878ed33
commit c86ad23703
4 changed files with 3 additions and 12 deletions
+3 -3
View File
@@ -87,9 +87,9 @@ class alignas(16) DynamicVstEvents {
*/
VstEvents& as_c_events();
// XXX: The original `VstEvents` stuct hasonly one C-style array of
// `VstEvent`s, but I've seen some implementation that have two. Is
// this only for alignment or does this have an actual use?
/**
* Midi events are sent in batches.
*/
std::vector<VstEvent> events;
private:
-5
View File
@@ -25,10 +25,6 @@
#include <iostream>
#include <random>
// TODO: I should track down the VST2 SDK for clarification on some of the
// implementation details, such as the use of intptr_t isntead of void*
// here.
namespace bp = boost::process;
// I'd rather use std::filesystem instead, but Boost.Process depends on
// boost::filesystem
@@ -278,7 +274,6 @@ void HostBridge::process_replacing(AEffect* /*plugin*/,
response =
read_object(host_vst_process_replacing, response, process_buffer);
// TODO: Doesn't quite work yet, not sure which side is causing problems
assert(response.buffers.size() == static_cast<size_t>(plugin.numOutputs));
for (int channel = 0; channel < plugin.numOutputs; channel++) {
std::copy(response.buffers[channel].begin(),
-2
View File
@@ -226,8 +226,6 @@ class HostCallbackDataConverter : DefaultDataConverter {
case audioMasterGetTime:
// Write the returned `VstTimeInfo` struct into a field and make
// the function return a poitner to it in the function below
// TODO: Start a time to update this on the host bridge once
// it's been requested. Not sure if this is needed though!
time = *static_cast<const VstTimeInfo*>(
static_cast<const void*>(response.data->data()));
break;
-2
View File
@@ -64,8 +64,6 @@ class PluginBridge {
/**
* With the `audioMasterGetTime` host callback the plugin expects the return
* value from the calblack to be a pointer to a VstTimeInfo struct.
*
* TODO: Should this be updated automatically?
*/
VstTimeInfo time_info;