mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-10 04:30:12 +02:00
Get rid of old todos
This commit is contained in:
@@ -87,9 +87,9 @@ class alignas(16) DynamicVstEvents {
|
|||||||
*/
|
*/
|
||||||
VstEvents& as_c_events();
|
VstEvents& as_c_events();
|
||||||
|
|
||||||
// XXX: The original `VstEvents` stuct hasonly one C-style array of
|
/**
|
||||||
// `VstEvent`s, but I've seen some implementation that have two. Is
|
* Midi events are sent in batches.
|
||||||
// this only for alignment or does this have an actual use?
|
*/
|
||||||
std::vector<VstEvent> events;
|
std::vector<VstEvent> events;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
|||||||
@@ -25,10 +25,6 @@
|
|||||||
#include <iostream>
|
#include <iostream>
|
||||||
#include <random>
|
#include <random>
|
||||||
|
|
||||||
// TODO: I should track down the VST2 SDK for clarification on some of the
|
|
||||||
// implementation details, such as the use of intptr_t isntead of void*
|
|
||||||
// here.
|
|
||||||
|
|
||||||
namespace bp = boost::process;
|
namespace bp = boost::process;
|
||||||
// I'd rather use std::filesystem instead, but Boost.Process depends on
|
// I'd rather use std::filesystem instead, but Boost.Process depends on
|
||||||
// boost::filesystem
|
// boost::filesystem
|
||||||
@@ -278,7 +274,6 @@ void HostBridge::process_replacing(AEffect* /*plugin*/,
|
|||||||
response =
|
response =
|
||||||
read_object(host_vst_process_replacing, response, process_buffer);
|
read_object(host_vst_process_replacing, response, process_buffer);
|
||||||
|
|
||||||
// TODO: Doesn't quite work yet, not sure which side is causing problems
|
|
||||||
assert(response.buffers.size() == static_cast<size_t>(plugin.numOutputs));
|
assert(response.buffers.size() == static_cast<size_t>(plugin.numOutputs));
|
||||||
for (int channel = 0; channel < plugin.numOutputs; channel++) {
|
for (int channel = 0; channel < plugin.numOutputs; channel++) {
|
||||||
std::copy(response.buffers[channel].begin(),
|
std::copy(response.buffers[channel].begin(),
|
||||||
|
|||||||
@@ -226,8 +226,6 @@ class HostCallbackDataConverter : DefaultDataConverter {
|
|||||||
case audioMasterGetTime:
|
case audioMasterGetTime:
|
||||||
// Write the returned `VstTimeInfo` struct into a field and make
|
// Write the returned `VstTimeInfo` struct into a field and make
|
||||||
// the function return a poitner to it in the function below
|
// the function return a poitner to it in the function below
|
||||||
// TODO: Start a time to update this on the host bridge once
|
|
||||||
// it's been requested. Not sure if this is needed though!
|
|
||||||
time = *static_cast<const VstTimeInfo*>(
|
time = *static_cast<const VstTimeInfo*>(
|
||||||
static_cast<const void*>(response.data->data()));
|
static_cast<const void*>(response.data->data()));
|
||||||
break;
|
break;
|
||||||
|
|||||||
@@ -64,8 +64,6 @@ class PluginBridge {
|
|||||||
/**
|
/**
|
||||||
* With the `audioMasterGetTime` host callback the plugin expects the return
|
* With the `audioMasterGetTime` host callback the plugin expects the return
|
||||||
* value from the calblack to be a pointer to a VstTimeInfo struct.
|
* value from the calblack to be a pointer to a VstTimeInfo struct.
|
||||||
*
|
|
||||||
* TODO: Should this be updated automatically?
|
|
||||||
*/
|
*/
|
||||||
VstTimeInfo time_info;
|
VstTimeInfo time_info;
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user