From c598ca08e1a4fe3eb4d7d43dee770606e65ae3a0 Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Wed, 8 Jun 2022 14:45:31 +0200
Subject: [PATCH] Update notifications for yabridge 4.0

---
 src/plugin/bridges/common.h | 22 +++++++++-------------
 src/plugin/vst2-plugin.cpp  |  3 ++-
 src/plugin/vst3-plugin.cpp  |  3 ++-
 3 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/src/plugin/bridges/common.h b/src/plugin/bridges/common.h
index ed6e2dca..9c21a864 100644
--- a/src/plugin/bridges/common.h
+++ b/src/plugin/bridges/common.h
@@ -206,15 +206,13 @@ class PluginBridge {
                 init_msg
                     << "   With a low memory locking limit, yabridge may not be"
                     << std::endl;
-                init_msg << "   be able to map enough shared memory for its "
-                            "audio buffers."
+                init_msg << "   be able to lock its shared memory audio "
+                            "buffers into";
+                init_msg << "   main memory. Performance may be degraded until "
+                            "you fix "
                          << std::endl;
-                init_msg
-                    << "   Plugins with many input or output channels may cause"
-                    << std::endl;
-                init_msg << "   yabridge to crash until you fix this. Check the"
-                         << std::endl;
-                init_msg << "   readme for instructions on how to do that."
+                init_msg << "   this. Check the readme for instructions on how "
+                            "to do that."
                          << std::endl;
                 init_msg << std::endl;
 
@@ -223,9 +221,9 @@ class PluginBridge {
                     "The current memlock limit is set to " +
                         std::to_string(*memlock_limit) +
                         " bytes. This means that you have not yet set up "
-                        "realtime privileges for your user, and some plugins "
-                        "may cause your DAW to crash until you fix this. Check "
-                        "the readme for instructions on how to do that.",
+                        "realtime privileges for your user, and performance "
+                        "may be degraded until you fix this. Check the readme "
+                        "for instructions on how to do that.",
                     std::nullopt);
             }
         } else {
@@ -388,8 +386,6 @@ class PluginBridge {
 
                     // Also show a desktop notification so users running from
                     // the GUI get a heads up
-                    // FIXME: Go through these messages and update them to
-                    //        reflect the chainloading changes
                     send_notification(
                         "Failed to start the Wine plugin host",
                         "Check yabridge's output for more information on what "
diff --git a/src/plugin/vst2-plugin.cpp b/src/plugin/vst2-plugin.cpp
index e5652d42..f00ad62e 100644
--- a/src/plugin/vst2-plugin.cpp
+++ b/src/plugin/vst2-plugin.cpp
@@ -56,7 +56,8 @@ void log_init_error(const std::exception& error, const fs::path& plugin_path) {
     // above message
     send_notification(
         "Failed to initialize VST2 plugin",
-        error.what() + "\nCheck the plugin's output for more information"s,
+        error.what() +
+            "\nCheck the plugin's output in a terminal for more information"s,
         plugin_path);
 }
 
diff --git a/src/plugin/vst3-plugin.cpp b/src/plugin/vst3-plugin.cpp
index 4d4db0d7..bcfbdc6f 100644
--- a/src/plugin/vst3-plugin.cpp
+++ b/src/plugin/vst3-plugin.cpp
@@ -81,7 +81,8 @@ void log_init_exception(const std::exception& error,
     // above message
     send_notification(
         "Failed to initialize VST3 plugin",
-        error.what() + "\nCheck the plugin's output for more information"s,
+        error.what() +
+            "\nCheck the plugin's output in a terminal for more information"s,
         plugin_path);
 }