From c57fd67aa87d873f9c684c7e9bcde8bf41789bba Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Thu, 3 Dec 2020 12:00:56 +0100 Subject: [PATCH] Don't store the Wine version as a field It's only needed for the initialisation message, and it doesn't throw so doing this later shouldn't make a difference. --- src/plugin/bridges/vst2.cpp | 3 +-- src/plugin/bridges/vst2.h | 6 ------ 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/plugin/bridges/vst2.cpp b/src/plugin/bridges/vst2.cpp index af513dfe..4bc237f4 100644 --- a/src/plugin/bridges/vst2.cpp +++ b/src/plugin/bridges/vst2.cpp @@ -61,7 +61,6 @@ Vst2PluginBridge::Vst2PluginBridge(audioMasterCallback host_callback) // This weird cast is not needed, but without it clang/ccls won't shut up logger(static_cast(Logger::create_from_environment( create_logger_prefix(sockets.base_dir)))), - wine_version(get_wine_version()), vst_host( config.group ? std::unique_ptr(std::make_unique( @@ -646,7 +645,7 @@ void Vst2PluginBridge::log_init_message() { } init_msg << "'" << std::endl; - init_msg << "wine version: '" << wine_version << "'" << std::endl; + init_msg << "wine version: '" << get_wine_version() << "'" << std::endl; init_msg << std::endl; // Print the path to the currently loaded configuration file and all diff --git a/src/plugin/bridges/vst2.h b/src/plugin/bridges/vst2.h index 09f15d56..967cd7a7 100644 --- a/src/plugin/bridges/vst2.h +++ b/src/plugin/bridges/vst2.h @@ -172,12 +172,6 @@ class Vst2PluginBridge { */ Vst2Logger logger; - /** - * The version of Wine currently in use. Used in the debug output on plugin - * startup. - */ - const std::string wine_version; - /** * The Wine process hosting the Windows VST plugin. *