From c36627f4c28643833635b6ec834c1bfdebc9472f Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 28 Oct 2022 19:50:32 +0200 Subject: [PATCH] Remove todo about using replaces_id --- src/common/notifications.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common/notifications.cpp b/src/common/notifications.cpp index f4cf2399..687c01e5 100644 --- a/src/common/notifications.cpp +++ b/src/common/notifications.cpp @@ -176,8 +176,10 @@ bool send_notification(const std::string& title, assert( libdbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &app_name)); - // TODO: Add the replacing thing, see if that helps prevent notifications - // from stacking up + // It would be nice to be able to replace old notifications so we don't + // accidentally spam the user when every plugin outputs the same message, + // but we can't really do this since during plugin scanning every plugin + // will likely be loaded in a fresh process const dbus_uint32_t replaces_id = 0; assert(libdbus_message_iter_append_basic(&iter, DBUS_TYPE_UINT32, &replaces_id));