From c1b4410e6b2c87712cc2f6b0d66f683ac422a0cd Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Tue, 17 Aug 2021 15:13:51 +0200
Subject: [PATCH] Don't include angular brackets for concrete types

In the VST2 log output. I just use this syntax as a more descriptive
handwavy substitute for the actual data.
---
 src/common/logging/vst2.cpp | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/common/logging/vst2.cpp b/src/common/logging/vst2.cpp
index ba36b393..23ed6f54 100644
--- a/src/common/logging/vst2.cpp
+++ b/src/common/logging/vst2.cpp
@@ -410,7 +410,7 @@ void Vst2Logger::log_event(
 
         std::visit(
             overload{
-                [&](const std::nullptr_t&) { message << "<nullptr>"; },
+                [&](const std::nullptr_t&) { message << "nullptr"; },
                 [&](const std::string& s) {
                     if (s.size() < 32) {
                         message << "\"" << s << "\"";
@@ -426,7 +426,7 @@ void Vst2Logger::log_event(
                 [&](const native_size_t& window_id) {
                     message << "<window " << window_id << ">";
                 },
-                [&](const AEffect&) { message << "<nullptr>"; },
+                [&](const AEffect&) { message << "nullptr"; },
                 [&](const DynamicVstEvents& events) {
                     message << "<" << events.events.size() << " midi_events";
                     if (!events.sysex_data.empty()) {
@@ -445,15 +445,13 @@ void Vst2Logger::log_event(
                 [&](const VstParameterProperties&) {
                     message << "<writable_buffer>";
                 },
-                [&](const WantsAEffectUpdate&) { message << "<nullptr>"; },
-                [&](const WantsAudioShmBufferConfig&) {
-                    message << "<nullptr>";
-                },
+                [&](const WantsAEffectUpdate&) { message << "nullptr"; },
+                [&](const WantsAudioShmBufferConfig&) { message << "nullptr"; },
                 [&](const WantsChunkBuffer&) {
                     message << "<writable_buffer>";
                 },
-                [&](const WantsVstRect&) { message << "<VstRect**>"; },
-                [&](const WantsVstTimeInfo&) { message << "<nullptr>"; },
+                [&](const WantsVstRect&) { message << "VstRect**"; },
+                [&](const WantsVstTimeInfo&) { message << "nullptr"; },
                 [&](const WantsString&) { message << "<writable_string>"; }},
             payload);
 
@@ -465,6 +463,7 @@ void Vst2Logger::log_event(
 
 void Vst2Logger::log_event_response(
     bool is_dispatch,
+    // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
     int opcode,
     intptr_t return_value,
     const Vst2EventResult::Payload& payload,