Re-introduce window resizing while draggin

This commit is contained in:
Robbert van der Helm
2020-04-12 19:42:12 +02:00
parent 3850e39777
commit c0eafc85fd
3 changed files with 33 additions and 4 deletions
+14 -4
View File
@@ -48,6 +48,16 @@ HWND Editor::open(AEffect* effect) {
return win32_handle->get();
}
bool Editor::resize(const int width, const int height) {
if (!win32_handle.has_value()) {
return false;
}
SetWindowPos(win32_handle->get(), HWND_TOP, 0, 0, width, height, 0);
return true;
}
void Editor::close() {
// RAII will destroy the window and tiemrs for us
win32_handle = std::nullopt;
@@ -129,10 +139,6 @@ void Editor::handle_events() {
break;
}
// The client area of the Win32 window doesn't expand
// automatically
SetWindowPos(win32_handle->get(), HWND_TOP, 0, 0,
event.width, event.height, 0);
// We're purposely not using XEmbed. This has the
// consequence that wine still thinks that any X and Y
@@ -156,6 +162,10 @@ void Editor::handle_events() {
XCB_EVENT_MASK_SUBSTRUCTURE_NOTIFY,
reinterpret_cast<char*>(&translated_event));
xcb_flush(x11_connection.get());
// The client area of the Win32 window doesn't expand
// automatically
resize(event.width, event.height);
} break;
}
free(generic_event);
+8
View File
@@ -57,6 +57,14 @@ class Editor {
void close();
/**
* Resize the window to match the given size, if open.
*
* @return Whether the resizing was succesful. Will return false if the
* editor isn't open.
*/
bool resize(const int width, const int height);
/**
* Embed the (open) window into a parent window.
*
+11
View File
@@ -298,6 +298,17 @@ class HostCallbackDataConverter : DefaultDataConverter {
case audioMasterGetTime:
return WantsVstTimeInfo{};
break;
case audioMasterSizeWindow:
// Plugins use this opcode to indicate that their editor should
// be resized. This is handled implicitly when handling the
// ConfigureNotify X11 events but handling this here as well
// makes the resizing look much smoother.
// TODO: Check if this actually makes drag resizing feel better,
// otherwise just remove this
editor.resize(value, index);
return DefaultDataConverter::read(opcode, index, value, data);
break;
case audioMasterIOChanged:
// This is a helpful event that indicates that the VST plugin's
// `AEffect` struct has changed. Writing these results back is