Add a proxy class for INoteExpressionPhysicalUIMapping

meson.build

@@ -135,6 +135,7 @@ vst3_plugin_sources = [
   'src/common/serialization/vst3/plugin/keyswitch-controller.cpp',
   'src/common/serialization/vst3/plugin/midi-mapping.cpp',
   'src/common/serialization/vst3/plugin/note-expression-controller.cpp',
+  'src/common/serialization/vst3/plugin/note-expression-physical-ui-mapping.cpp',
   'src/common/serialization/vst3/plugin/plugin-base.cpp',
   'src/common/serialization/vst3/plugin/prefetchable-support.cpp',
   'src/common/serialization/vst3/plugin/program-list-data.cpp',
@@ -216,6 +217,7 @@ if with_vst3
     'src/common/serialization/vst3/plugin/keyswitch-controller.cpp',
     'src/common/serialization/vst3/plugin/midi-mapping.cpp',
     'src/common/serialization/vst3/plugin/note-expression-controller.cpp',
+    'src/common/serialization/vst3/plugin/note-expression-physical-ui-mapping.cpp',
     'src/common/serialization/vst3/plugin/plugin-base.cpp',
     'src/common/serialization/vst3/plugin/prefetchable-support.cpp',
     'src/common/serialization/vst3/plugin/program-list-data.cpp',

src/common/serialization/vst3/README.md

@@ -13,7 +13,7 @@ The following interfaces are not yet implemented:
 VST3 plugin interfaces are implemented as follows:
 
 | yabridge class                      | Included in         | Interfaces                                             |
-| ------------------------------- | ------------------- | ------------------------------------------------------ |
+| ----------------------------------- | ------------------- | ------------------------------------------------------ |
 | `YaPluginFactory`                   |                     | `IPluginFactory`, `IPluginFactory2`, `IPluginFactory3` |
 | `Vst3ConnectionPointProxy`          |                     | `IConnectionPoint` through `YaConnectionPoint`         |
 | `Vst3PlugViewProxy`                 |                     | All of the below:                                      |
@@ -33,6 +33,7 @@ VST3 plugin interfaces are implemented as follows:
 | `YaKeyswitchController`             | `Vst3PluginProxy`   | `IKeyswitchController`                                 |
 | `YaMidiMapping`                     | `Vst3PluginProxy`   | `IMidiMapping`                                         |
 | `YaNoteExpressionController`        | `Vst3PluginProxy`   | `INoteExpressionController`                            |
+| `YaNoteExpressionPhysicalUIMapping` | `Vst3PluginProxy`   | `INoteExpressionPhysicalUIMapping`                     |
 | `YaPluginBase`                      | `Vst3PluginProxy`   | `IPluginBase`                                          |
 | `YaPrefetchableSupport`             | `Vst3PluginProxy`   | `IPrefetchableSupport`                                 |
 | `YaProgramListData`                 | `Vst3PluginProxy`   | `IProgramListData`                                     |

src/common/serialization/vst3/plugin/note-expression-physical-ui-mapping.cpp

@@ -0,0 +1,28 @@
+// yabridge: a Wine VST bridge
+// Copyright (C) 2020-2021 Robbert van der Helm
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+#include "note-expression-physical-ui-mapping.h"
+
+YaNoteExpressionPhysicalUIMapping::ConstructArgs::ConstructArgs() {}
+
+YaNoteExpressionPhysicalUIMapping::ConstructArgs::ConstructArgs(
+    Steinberg::IPtr<Steinberg::FUnknown> object)
+    : supported(Steinberg::FUnknownPtr<
+                Steinberg::Vst::INoteExpressionPhysicalUIMapping>(object)) {}
+
+YaNoteExpressionPhysicalUIMapping::YaNoteExpressionPhysicalUIMapping(
+    const ConstructArgs&& args)
+    : arguments(std::move(args)) {}

src/common/serialization/vst3/plugin/note-expression-physical-ui-mapping.h

@@ -0,0 +1,76 @@
+// yabridge: a Wine VST bridge
+// Copyright (C) 2020-2021 Robbert van der Helm
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+#pragma once
+
+#include <pluginterfaces/vst/ivstphysicalui.h>
+
+#include "../../common.h"
+#include "../base.h"
+#include "../physical-ui-map-list.h"
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
+
+/**
+ * Wraps around `INoteExpressionPhysicalUIMapping` for serialization purposes.
+ * This is instantiated as part of `Vst3PluginProxy`.
+ */
+class YaNoteExpressionPhysicalUIMapping
+    : public Steinberg::Vst::INoteExpressionPhysicalUIMapping {
+   public:
+    /**
+     * These are the arguments for creating a
+     * `YaNoteExpressionPhysicalUIMapping`.
+     */
+    struct ConstructArgs {
+        ConstructArgs();
+
+        /**
+         * Check whether an existing implementation implements
+         * `INoteExpressionPhysicalUIMapping` and read arguments from it.
+         */
+        ConstructArgs(Steinberg::IPtr<Steinberg::FUnknown> object);
+
+        /**
+         * Whether the object supported this interface.
+         */
+        bool supported;
+
+        template <typename S>
+        void serialize(S& s) {
+            s.value1b(supported);
+        }
+    };
+
+    /**
+     * Instantiate this instance with arguments read from another interface
+     * implementation.
+     */
+    YaNoteExpressionPhysicalUIMapping(const ConstructArgs&& args);
+
+    inline bool supported() const { return arguments.supported; }
+
+    virtual tresult PLUGIN_API
+    getPhysicalUIMapping(int32 busIndex,
+                         int16 channel,
+                         Steinberg::Vst::PhysicalUIMapList& list) override = 0;
+
+   protected:
+    ConstructArgs arguments;
+};
+
+#pragma GCC diagnostic pop