From be11364c58bd59029cc70e3458d66e0dc09aa5af Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Mon, 9 Mar 2020 14:39:19 +0100
Subject: [PATCH] Remvoe the bitsery c-array attempt

I'll just use vectors and a thin wrapper instead, shouldn't have much
overhead.
---
 src/common/bitsery.h       | 66 --------------------------------------
 src/common/serialization.h |  1 -
 2 files changed, 67 deletions(-)
 delete mode 100644 src/common/bitsery.h

diff --git a/src/common/bitsery.h b/src/common/bitsery.h
deleted file mode 100644
index 15c9abed..00000000
--- a/src/common/bitsery.h
+++ /dev/null
@@ -1,66 +0,0 @@
-// yabridge: a Wine VST bridge
-// Copyright (C) 2020  Robbert van der Helm
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-#pragma once
-
-// This is a modified version of `bitsery::ext::PointerOwner` in an attempt to
-// support C-style arrays with no compile time known length. This should be
-// upstreamed if it works.
-
-#include <bitsery/ext/pointer.h>
-
-// TODO: Implement
-
-namespace bitsery {
-namespace ext {
-template <template <typename> class TPtrManager,
-          template <typename>
-          class TPolymorphicContext,
-          typename RTTI>
-class MultiplePointerObjectExtensionBase
-    : public pointer_utils::
-          PointerObjectExtensionBase<TPtrManager, TPolymorphicContext, RTTI> {
-    // explicit PointerObjectExtensionBase(
-    //     PointerType ptrType = PointerType::Nullable,
-    //     MemResourceBase* resource = nullptr,
-    //     bool resourcePropagate = false)
-    //     : _ptrType{ptrType},
-    //       _resourcePropagate{resourcePropagate},
-    //       _resource{resource} {}
-};
-
-template <typename RTTI>
-using MultiplePointerOwnerBase =
-    MultiplePointerObjectExtensionBase<pointer_details::PtrOwnerManager,
-                                       PolymorphicContext,
-                                       RTTI>;
-
-using MultiplePointerOwner = MultiplePointerOwnerBase<StandardRTTI>;
-
-}  // namespace ext
-
-namespace traits {
-template <typename T, typename RTTI>
-struct ExtensionTraits<ext::MultiplePointerOwnerBase<RTTI>, T*> {
-    using TValue = T;
-    static constexpr bool SupportValueOverload = true;
-    static constexpr bool SupportObjectOverload = true;
-    // if underlying type is not polymorphic, then we can enable lambda syntax
-    static constexpr bool SupportLambdaOverload =
-        !RTTI::template isPolymorphic<TValue>();
-};
-}  // namespace traits
-}  // namespace bitsery
diff --git a/src/common/serialization.h b/src/common/serialization.h
index 89a6c6bf..7842c625 100644
--- a/src/common/serialization.h
+++ b/src/common/serialization.h
@@ -25,7 +25,6 @@
 
 #include <variant>
 
-#include "bitsery.h"
 
 /**
  * The maximum number of audio channels supported.