mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-09 20:29:10 +02:00
Implement IEditController::createView()
Even though `Vst3PlugViewProxyImpl` is still only stubs, `IEditController` is now fully implemented.
This commit is contained in:
@@ -19,7 +19,8 @@ incomplete list of things that still have to be done before this can be used:
|
|||||||
- `IHostApplication::createComponent()`
|
- `IHostApplication::createComponent()`
|
||||||
- `IConnectionPoint::notify()`, and support for indirectly connecting
|
- `IConnectionPoint::notify()`, and support for indirectly connecting
|
||||||
components through message passing proxies
|
components through message passing proxies
|
||||||
- Finish implementing `IEditController{,2}`
|
- `IPlugView`
|
||||||
|
- `IEditController2`
|
||||||
- All other mandatory interfaces
|
- All other mandatory interfaces
|
||||||
- All other optional interfaces
|
- All other optional interfaces
|
||||||
- Fully implemented: see [this
|
- Fully implemented: see [this
|
||||||
|
|||||||
@@ -16,6 +16,8 @@
|
|||||||
|
|
||||||
#include "plugin-proxy.h"
|
#include "plugin-proxy.h"
|
||||||
|
|
||||||
|
#include "plug-view-proxy.h"
|
||||||
|
|
||||||
Vst3PluginProxyImpl::Vst3PluginProxyImpl(Vst3PluginBridge& bridge,
|
Vst3PluginProxyImpl::Vst3PluginProxyImpl(Vst3PluginBridge& bridge,
|
||||||
Vst3PluginProxy::ConstructArgs&& args)
|
Vst3PluginProxy::ConstructArgs&& args)
|
||||||
: Vst3PluginProxy(std::move(args)), bridge(bridge) {
|
: Vst3PluginProxy(std::move(args)), bridge(bridge) {
|
||||||
@@ -355,27 +357,35 @@ tresult PLUGIN_API Vst3PluginProxyImpl::setComponentHandler(
|
|||||||
|
|
||||||
Steinberg::IPlugView* PLUGIN_API
|
Steinberg::IPlugView* PLUGIN_API
|
||||||
Vst3PluginProxyImpl::createView(Steinberg::FIDString name) {
|
Vst3PluginProxyImpl::createView(Steinberg::FIDString name) {
|
||||||
// TODO: Implement
|
CreateViewResponse response =
|
||||||
bridge.logger.log("TODO IEditController::createView()");
|
bridge.send_message(YaEditController::CreateView{
|
||||||
return nullptr;
|
.instance_id = instance_id(), .name = name});
|
||||||
|
|
||||||
|
if (response.plug_view_args) {
|
||||||
|
// The host should manage this. Returning raw pointers feels scary.
|
||||||
|
return new Vst3PlugViewProxyImpl(bridge,
|
||||||
|
std::move(*response.plug_view_args));
|
||||||
|
} else {
|
||||||
|
return nullptr;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
tresult PLUGIN_API
|
tresult PLUGIN_API
|
||||||
Vst3PluginProxyImpl::setKnobMode(Steinberg::Vst::KnobMode mode) {
|
Vst3PluginProxyImpl::setKnobMode(Steinberg::Vst::KnobMode mode) {
|
||||||
// TODO: Implement
|
// TODO: Implement
|
||||||
bridge.logger.log("TODO IEditController2::setKnobMode()");
|
bridge.logger.log("TODO: IEditController2::setKnobMode()");
|
||||||
return Steinberg::kNotImplemented;
|
return Steinberg::kNotImplemented;
|
||||||
}
|
}
|
||||||
|
|
||||||
tresult PLUGIN_API Vst3PluginProxyImpl::openHelp(TBool onlyCheck) {
|
tresult PLUGIN_API Vst3PluginProxyImpl::openHelp(TBool onlyCheck) {
|
||||||
// TODO: Implement
|
// TODO: Implement
|
||||||
bridge.logger.log("TODO IEditController2::openHelp()");
|
bridge.logger.log("TODO: IEditController2::openHelp()");
|
||||||
return Steinberg::kNotImplemented;
|
return Steinberg::kNotImplemented;
|
||||||
}
|
}
|
||||||
|
|
||||||
tresult PLUGIN_API Vst3PluginProxyImpl::openAboutBox(TBool onlyCheck) {
|
tresult PLUGIN_API Vst3PluginProxyImpl::openAboutBox(TBool onlyCheck) {
|
||||||
// TODO: Implement
|
// TODO: Implement
|
||||||
bridge.logger.log("TODO IEditController2::openAboutBox()");
|
bridge.logger.log("TODO: IEditController2::openAboutBox()");
|
||||||
return Steinberg::kNotImplemented;
|
return Steinberg::kNotImplemented;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user