Don't cache reconstructed VST3 events at all

There's no need to since reconstructing the event is very cheap, and
this should be faster (less memory used) and also less error prone
anyways.

src/common/serialization/vst3/event-list.cpp

@@ -227,21 +227,10 @@ tresult PLUGIN_API YaEventList::getEvent(int32 index,
         return Steinberg::kInvalidArgument;
     }
 
-    // On the first call to this, we'll reconstruct `Event` objects out of our
+    // Reconstructing an event is cheap, but some events may contain pointers to
-    // `YaEvent`s all at once. This is also done if for whatever reason the
+    // heap data stored within the `events` vector so this event will still have
-    // plugin `getEvent()`s an event it just added.
+    // the same lifetime as this class
-    const size_t num_already_reconstructed_events = reconstructed_events.size();
+    e = events[index].get();
-    if (index >= static_cast<int32>(num_already_reconstructed_events)) {
-        reconstructed_events.resize(events.size());
-        std::transform(
-            events.begin() + static_cast<int>(num_already_reconstructed_events),
-            events.end(),
-            reconstructed_events.begin() +
-                static_cast<int>(num_already_reconstructed_events),
-            [](const YaEvent& event) { return event.get(); });
-    }
-
-    e = reconstructed_events[index];
 
     return Steinberg::kResultOk;
 }

src/common/serialization/vst3/event-list.h

@@ -257,21 +257,10 @@ class YaEventList : public Steinberg::Vst::IEventList {
     template <typename S>
     void serialize(S& s) {
         s.container(events, 1 << 16);
-
-        // NOTE: After deserializing events, we need to make sure to clear our
-        //       caches since those may still contain old events
-        reconstructed_events.clear();
     }
 
    private:
     boost::container::small_vector<YaEvent, 64> events;
-
-    /**
-     * On the first `getEvent()` call we'll reconstruct these from `events` all
-     * at once. These event objects may not outlive this event list.
-     */
-    boost::container::small_vector<Steinberg::Vst::Event, 64>
-        reconstructed_events;
 };
 
 #pragma GCC diagnostic pop