vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-13 20:09:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove are_objects_directly_connected check

Browse Source 
It's not necessary, since all of these objects are simple data objects
that will be passed as arguments to other functions. When we have to
pass through one of those functions we can just serialize the objects at
that point.
This commit is contained in:
Robbert van der Helm
2020-12-24 14:39:25 +01:00
parent 50b50418f4
commit b0fc8f2c5f
4 changed files with 18 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst3-impls/host-context-proxy.cpp
+17 -31
View File
@@ -66,40 +66,26 @@ Vst3HostContextProxyImpl::createInstance(Steinberg::TUID /*cid*/,
return Steinberg::kInvalidArgument;
}
// These objects don't have to be created by the actual host since they'll
// only be used as an argument to other functions. We can just serialize
// them at that point.
Steinberg::FUID iid = Steinberg::FUID::fromTUID(_iid);
// If an objects wants to create an `IMessage` object to send it to some
// object it is directly connected to, then we can keep everything local
// on the Wine side. This is mostly an optimization, because it saves a
// lot of unnecessary back and forth communication.
if (are_objects_directly_connected) {
if (iid == Steinberg::Vst::IMessage::iid) {
// TODO: Add logging for this on verbosity level 1
*obj = new Steinberg::Vst::HostMessage{};
return Steinberg::kResultTrue;
} else if (iid == Steinberg::Vst::IAttributeList::iid) {
// TODO: Add logging for this on verbosity level 1
*obj = new Steinberg::Vst::HostAttributeList{};
return Steinberg::kResultTrue;
} else {
// When the host requests an interface we do not (yet) implement,
// we'll print a recognizable log message
const Steinberg::FUID uid = Steinberg::FUID::fromTUID(_iid);
std::cerr
<< "TODO: Implement unknown interface logging on Wine side "
"for Vst3HostContextProxyImpl::createInstance"
<< std::endl;
return Steinberg::kNotImplemented;
}
if (iid == Steinberg::Vst::IMessage::iid) {
// TODO: Add logging for this on verbosity level 1
*obj = new Steinberg::Vst::HostMessage{};
return Steinberg::kResultTrue;
} else if (iid == Steinberg::Vst::IAttributeList::iid) {
// TODO: Add logging for this on verbosity level 1
*obj = new Steinberg::Vst::HostAttributeList{};
return Steinberg::kResultTrue;
} else {
// TODO: Implement for objects that are not directly connected
std::cerr
<< "TODO: Creating <IMessage*> and <IAttributeList*> instances in "
"IHostApplication::createInstance() for indirectly "
"connected objects has not yet been implemented"
<< std::endl;
// When the host requests an interface we do not (yet) implement,
// we'll print a recognizable log message
const Steinberg::FUID uid = Steinberg::FUID::fromTUID(_iid);
std::cerr << "TODO: Implement unknown interface logging on Wine side "
"for Vst3HostContextProxyImpl::createInstance"
<< std::endl;
*obj = nullptr;
return Steinberg::kNotImplemented;
}
}