vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't copy any VST3 state preamble

Browse Source 
Bitwig prepends some data when passing an `IBStream*` to the plugin, and
when we do copy it iZotope Rx7 plugins cannot load their state (even if
we also copy over the same seek position). Not copying that preamble
fixes the issue, and it seems like it doesn't break anything.
This commit is contained in:
Robbert van der Helm
2021-05-02 21:59:26 +02:00
parent dc37f03613
commit a9f9691b42
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3/bstream.cpp
+11 -1
View File
@@ -30,21 +30,31 @@ YaBStream::YaBStream(Steinberg::IBStream* stream) {
// Copy any existing contents, used for `IComponent::setState` and similar
// methods
// NOTE: Bitwig Studio seems to prepend some default header on new presets
// We _don't_ want to copy that, since some plugins may try to read
// the entire preset and fail to load. Examples of such plugins are
// the iZotope Rx7 plugins.
int64 old_position;
stream->tell(&old_position);
if (stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekEnd) ==
Steinberg::kResultOk) {
int64 size = 0;
stream->tell(&size);
size -= old_position;
if (size > 0) {
int32 num_bytes_read = 0;
buffer.resize(size);
stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);
stream->seek(old_position,
Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);
stream->read(buffer.data(), static_cast<int32>(size),
&num_bytes_read);
assert(num_bytes_read == 0 || num_bytes_read == size);
}
}
// If the host did prepend some header, we should leave it in place when
// writing
stream->seek(old_position,
Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);