mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-10 04:30:12 +02:00
Add todo regarding audioMasterGetTime
This commit is contained in:
@@ -66,8 +66,9 @@ void Editor::close() {
|
||||
// RAII will destroy the window and tiemrs for us
|
||||
win32_handle = std::nullopt;
|
||||
|
||||
// TODO: Do we need to do something on the X11 side or does the host do
|
||||
// everything for us?
|
||||
// TODO: We might want to manually unmap the X11 window instead of having
|
||||
// the host do it. Right now the window editor window stays open for a
|
||||
// second when removing a plugin.
|
||||
}
|
||||
|
||||
bool Editor::embed_into(const size_t parent_window_handle) {
|
||||
|
||||
@@ -328,6 +328,7 @@ class HostCallbackDataConverter : DefaultDataConverter {
|
||||
case audioMasterGetTime:
|
||||
// Return a pointer to the `VstTimeInfo` object written in the
|
||||
// function above
|
||||
// TODO: This is incorrect!
|
||||
return reinterpret_cast<intptr_t>(&time);
|
||||
break;
|
||||
default:
|
||||
@@ -338,6 +339,7 @@ class HostCallbackDataConverter : DefaultDataConverter {
|
||||
|
||||
private:
|
||||
AEffect* plugin;
|
||||
// TODO: Clean up
|
||||
Editor& editor;
|
||||
VstTimeInfo& time_info;
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user