Log successful FUnknown::queryInterface calls

This commit is contained in:
Robbert van der Helm
2020-12-31 13:13:39 +01:00
parent 26bc97e273
commit 9d24d422d1
9 changed files with 38 additions and 46 deletions
@@ -30,12 +30,9 @@ Vst3PlugViewProxyImpl::~Vst3PlugViewProxyImpl() {
tresult PLUGIN_API
Vst3PlugViewProxyImpl::queryInterface(const Steinberg::TUID _iid, void** obj) {
// TODO: Successful queries should also be logged
const tresult result = Vst3PlugViewProxy::queryInterface(_iid, obj);
if (result != Steinberg::kResultOk) {
bridge.logger.log_unknown_interface("In IPlugView::queryInterface()",
Steinberg::FUID::fromTUID(_iid));
}
bridge.logger.log_query_interface("In IPlugView::queryInterface()", result,
Steinberg::FUID::fromTUID(_iid));
return result;
}
@@ -59,8 +59,8 @@ YaPluginFactoryImpl::createInstance(Steinberg::FIDString cid,
// to do.
const Steinberg::FUID uid = Steinberg::FUID::fromTUID(
*reinterpret_cast<const Steinberg::TUID*>(&*_iid));
bridge.logger.log_unknown_interface(
"In IPluginFactory::createInstance()", uid);
bridge.logger.log_query_interface("In IPluginFactory::createInstance()",
Steinberg::kNotImplemented, uid);
*obj = nullptr;
return Steinberg::kNotImplemented;
@@ -32,12 +32,9 @@ Vst3PluginProxyImpl::~Vst3PluginProxyImpl() {
tresult PLUGIN_API
Vst3PluginProxyImpl::queryInterface(const Steinberg::TUID _iid, void** obj) {
// TODO: Successful queries should also be logged
const tresult result = Vst3PluginProxy::queryInterface(_iid, obj);
if (result != Steinberg::kResultOk) {
bridge.logger.log_unknown_interface("In FUnknown::queryInterface()",
Steinberg::FUID::fromTUID(_iid));
}
bridge.logger.log_query_interface("In FUnknown::queryInterface()", result,
Steinberg::FUID::fromTUID(_iid));
return result;
}