Remove non-existent VST2 entry point

Since there isn't any public documentation on VST2, I saw JUCE and a
couple of other plugins and bridges use this, but they all redefined the
symbol to`main`.
This commit is contained in:
Robbert van der Helm
2021-06-29 12:11:05 +02:00
parent c067cd1b40
commit 9b1f3a5f4c
3 changed files with 5 additions and 5 deletions
+2 -2
View File
@@ -144,9 +144,9 @@ Vst2Bridge::Vst2Bridge(MainContext& main_context,
} }
// VST plugin entry point functions should be called `VSTPluginMain`, but // VST plugin entry point functions should be called `VSTPluginMain`, but
// there are some older deprecated names that legacy plugins may still use // pre-VST2.4 `main` was also a valid name
VstEntryPoint vst_entry_point = nullptr; VstEntryPoint vst_entry_point = nullptr;
for (auto name : {"VSTPluginMain", "main_plugin", "main"}) { for (auto name : {"VSTPluginMain", "main"}) {
vst_entry_point = vst_entry_point =
reinterpret_cast<VstEntryPoint>(reinterpret_cast<size_t>( reinterpret_cast<VstEntryPoint>(reinterpret_cast<size_t>(
GetProcAddress(plugin_handle.get(), name))); GetProcAddress(plugin_handle.get(), name)));
+2 -2
View File
@@ -101,7 +101,7 @@ yabridge_home=$HOME/.local/share/yabridge
plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins" plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins"
find -L "$plugin_dir" -type f -iname '*.dll' -print0 | find -L "$plugin_dir" -type f -iname '*.dll' -print0 |
xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main|main_plugin') && printf '{}\0'" | xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main') && printf '{}\0'" |
sed -z 's/\.dll$/.so/' | sed -z 's/\.dll$/.so/' |
xargs -0 -n1 ln -sf "$yabridge_home/libyabridge.so" xargs -0 -n1 ln -sf "$yabridge_home/libyabridge.so"
@@ -110,7 +110,7 @@ yabridge_home=$HOME/.local/share/yabridge
plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins" plugin_dir="$HOME/.wine/drive_c/Program Files/Steinberg/VstPlugins"
find -L "$plugin_dir" -type f -iname '*.dll' -print0 | find -L "$plugin_dir" -type f -iname '*.dll' -print0 |
xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main|main_plugin') && printf '{}\0'" | xargs -0 -P$(nproc) -I{} bash -c "(winedump -j export '{}' | grep -qE 'VSTPluginMain|main') && printf '{}\0'" |
sed -z 's/\.dll$/.so/' | sed -z 's/\.dll$/.so/' |
xargs -0 -n1 cp "$yabridge_home/libyabridge.so" xargs -0 -n1 cp "$yabridge_home/libyabridge.so"
``` ```
+1 -1
View File
@@ -392,7 +392,7 @@ impl SearchIndex {
pub fn search(self) -> Result<SearchResults> { pub fn search(self) -> Result<SearchResults> {
lazy_static! { lazy_static! {
static ref VST2_AUTOMATON: AhoCorasick = static ref VST2_AUTOMATON: AhoCorasick =
AhoCorasick::new_auto_configured(&["VSTPluginMain", "main", "main_plugin"]); AhoCorasick::new_auto_configured(&["VSTPluginMain", "main"]);
static ref VST3_AUTOMATON: AhoCorasick = static ref VST3_AUTOMATON: AhoCorasick =
AhoCorasick::new_auto_configured(&["GetPluginFactory"]); AhoCorasick::new_auto_configured(&["GetPluginFactory"]);
static ref DLL32_AUTOMATON: AhoCorasick = static ref DLL32_AUTOMATON: AhoCorasick =