From 957da621375c3d2e53fa1252a20aaa7f5b02021a Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Sat, 6 Jun 2020 12:43:35 +0200
Subject: [PATCH] Add missing type qualifiers

---
 src/plugin/utils.cpp     | 6 +++---
 src/plugin/utils.h       | 6 +++---
 src/wine-host/editor.cpp | 2 +-
 src/wine-host/editor.h   | 2 +-
 src/wine-host/utils.cpp  | 3 +--
 5 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/plugin/utils.cpp b/src/plugin/utils.cpp
index 98244e42..581482b6 100644
--- a/src/plugin/utils.cpp
+++ b/src/plugin/utils.cpp
@@ -165,9 +165,9 @@ fs::path find_vst_plugin() {
 }
 
 boost::filesystem::path generate_group_endpoint(
-    std::string group_name,
-    boost::filesystem::path wine_prefix,
-    PluginArchitecture architecture) {
+    const std::string& group_name,
+    const boost::filesystem::path& wine_prefix,
+    const PluginArchitecture architecture) {
     std::ostringstream socket_name;
     socket_name << "yabridge-group-" << group_name << "-"
                 << std::to_string(
diff --git a/src/plugin/utils.h b/src/plugin/utils.h
index 2cbad0a0..9cd721b4 100644
--- a/src/plugin/utils.h
+++ b/src/plugin/utils.h
@@ -134,9 +134,9 @@ std::optional<boost::filesystem::path> find_wineprefix();
  * above.
  */
 boost::filesystem::path generate_group_endpoint(
-    std::string group_name,
-    boost::filesystem::path wine_prefix,
-    PluginArchitecture architecture);
+    const std::string& group_name,
+    const boost::filesystem::path& wine_prefix,
+    const PluginArchitecture architecture);
 
 /**
  * Generate a unique name for the Unix domain socket endpoint based on the VST
diff --git a/src/wine-host/editor.cpp b/src/wine-host/editor.cpp
index d4d3c418..794248f1 100644
--- a/src/wine-host/editor.cpp
+++ b/src/wine-host/editor.cpp
@@ -48,7 +48,7 @@ Size get_maximum_screen_dimensions(xcb_connection_t& x11_connection);
 xcb_window_t get_x11_handle(HWND win32_handle);
 ATOM register_window_class(std::string window_class_name);
 
-WindowClass::WindowClass(std::string name)
+WindowClass::WindowClass(const std::string& name)
     : atom(register_window_class(name)) {}
 
 WindowClass::~WindowClass() {
diff --git a/src/wine-host/editor.h b/src/wine-host/editor.h
index fb0a4198..92576eb0 100644
--- a/src/wine-host/editor.h
+++ b/src/wine-host/editor.h
@@ -48,7 +48,7 @@ struct Size {
  */
 class WindowClass {
    public:
-    WindowClass(std::string name);
+    explicit WindowClass(const std::string& name);
     ~WindowClass();
 
     /**
diff --git a/src/wine-host/utils.cpp b/src/wine-host/utils.cpp
index a5b7f4e3..cc26ffb4 100644
--- a/src/wine-host/utils.cpp
+++ b/src/wine-host/utils.cpp
@@ -31,8 +31,7 @@ Win32Timer::~Win32Timer() {
     }
 }
 
-Win32Timer::Win32Timer(Win32Timer&& o) {
-    timer_id = o.timer_id;
+Win32Timer::Win32Timer(Win32Timer&& o) : timer_id(o.timer_id) {
     o.timer_id = std::nullopt;
 }