Add explicit virtual default destructors

We need to silence the warning about this because Steinberg doesn't
declare their base class destructors as virtual (because of Windows ABI
compatibility issues). But we can still do it inside of yabridge to have
at least a bit more safety.
This commit is contained in:
Robbert van der Helm
2022-05-18 18:44:15 +02:00
parent 3e73d60b78
commit 8c10edf861
53 changed files with 93 additions and 23 deletions
+1 -1
View File
@@ -129,7 +129,7 @@ class PluginBridge {
io_context_.run();
}) {}
virtual ~PluginBridge() noexcept {};
virtual ~PluginBridge() noexcept = default;
protected:
/**
@@ -49,7 +49,7 @@ class RunLoopTasks : public Steinberg::Linux::IEventHandler {
/**
* Unregister the event handler and close the file descriptor on cleanup.
*/
~RunLoopTasks();
virtual ~RunLoopTasks();
DECLARE_FUNKNOWN_METHODS
@@ -390,6 +390,7 @@ Vst3PluginProxyImpl::getBusInfo(Steinberg::Vst::MediaType type,
}
tresult PLUGIN_API Vst3PluginProxyImpl::getRoutingInfo(
// NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
Steinberg::Vst::RoutingInfo& inInfo,
Steinberg::Vst::RoutingInfo& outInfo /*out*/) {
const GetRoutingInfoResponse response =
-2
View File
@@ -25,8 +25,6 @@ namespace fs = ghc::filesystem;
HostProcess::HostProcess(asio::io_context& io_context, Sockets& sockets)
: sockets_(sockets), stdout_pipe_(io_context), stderr_pipe_(io_context) {}
HostProcess::~HostProcess() noexcept {}
Process::Handle HostProcess::launch_host(
const ghc::filesystem::path& host_path,
std::initializer_list<std::string> args,
+1 -1
View File
@@ -37,7 +37,7 @@
*/
class HostProcess {
public:
virtual ~HostProcess() noexcept;
virtual ~HostProcess() noexcept = default;
/**
* Return the full path to the host application in use. The host application