mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-10 04:30:12 +02:00
Manually close descriptors instead of using vfork
With `vfork()` the child process inherits the parents process image and prevents copying them, but if it outlives its parent then the file descriptors will still remain open. Manually closing all file descriptors is the only solution here. This was only an issue with Ardour since they don't open all of their files with `FD_CLOEXEC`. Last update's watchdog timer somewhat mitigated the issue, but Ardour should now no longer freeze when reopening because of this. The watchdog timer is still necessary, since hanging Wine processes will still prevent the Wine server from shutting down.
This commit is contained in:
@@ -31,6 +31,12 @@ Versioning](https://semver.org/spec/v2.0.0.html).
|
||||
|
||||
### Fixed
|
||||
|
||||
- Fixed yabridge's Wine processes inheriting file descriptors in some
|
||||
situations. This could cause **Ardour** and **Mixbus** to hang when trying to
|
||||
reopen it after a crash. The watchdog timer added in yabridge 3.2.0 also
|
||||
addressed this issue partially, but it should now be completely fixed. This
|
||||
may also prevent rare issues where the **JACK** server would hang after the
|
||||
host crashes.
|
||||
- Fixed _DMG_ VST3 plugins freezing in **REAPER** when the plugin resizes itself
|
||||
while the host passes channel context information to the plugin.
|
||||
- Also fixed _DMG_ VST3 plugins freezing in **REAPER** when restoring multiple
|
||||
|
||||
Reference in New Issue
Block a user