vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

[yabridgectl] Partially revert 5ea04c4

Browse Source 
We should be a bit more clever about this. This approach would mean that
the plugin would be rescanned every time, since the whole 'don't
reinstall plugins if that wouldn't change anything' thing no longer
works with this approach.
This commit is contained in:
Robbert van der Helm
2021-07-03 16:37:02 +02:00
parent e0b06c84ce
commit 85c84aba0f
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/yabridgectl/src/actions.rs
+11 -9
View File
@@ -306,15 +306,17 @@ pub fn do_sync(config: &mut Config, options: &SyncOptions) -> Result<()> {
continue; continue;
} }
// NOTE: We need to make sure the VST3 bundle is completely empty before setting // FIXME: We should be more specific in this process and only remove the
// it up. Otherwise you would it would contain orphan plugin files after // unwanted directories from `Contents`, because this will force rescans
// uninstalling the 32-bit version of a VST3 plugin while the 64-bit // // NOTE: We need to make sure the VST3 bundle is completely empty before setting
// version is still installed, or when switching between the 32-bit and // // it up. Otherwise you would it would contain orphan plugin files after
// the 64-bit versions of yabridge // // uninstalling the 32-bit version of a VST3 plugin while the 64-bit
if !*updated_libyabridge && target_bundle_home.exists() { // // version is still installed, or when switching between the 32-bit and
utils::remove_dir_all(target_bundle_home) // // the 64-bit versions of yabridge
.context("Could not clean up old VST3 bundle")?; // if !*updated_libyabridge && target_bundle_home.exists() {
} // utils::remove_dir_all(target_bundle_home)
// .context("Could not clean up old VST3 bundle")?;
// }
// We're building a merged VST3 bundle containing both a copy or symlink to // We're building a merged VST3 bundle containing both a copy or symlink to
// `libyabridge-vst3.so` and the Windows VST3 plugin. The path to this native // `libyabridge-vst3.so` and the Windows VST3 plugin. The path to this native