vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Prevent unnecessary copies in VST2 event handling

Browse Source
This commit is contained in:
Robbert van der Helm
2021-06-10 17:31:19 +02:00
parent 1bc804965c
commit 80fa010af5
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin/bridges/vst2.cpp
+7 -6
View File
@@ -341,7 +341,8 @@ class DispatchDataConverter : public DefaultDataConverter {
// coded late initialing plugins. Hopefully the host will see // coded late initialing plugins. Hopefully the host will see
// that the object is updated because these plugins don't send // that the object is updated because these plugins don't send
// any notification about this. // any notification about this.
const auto updated_plugin = std::get<AEffect>(response.payload); const auto& updated_plugin =
std::get<AEffect>(response.payload);
update_aeffect(plugin, updated_plugin); update_aeffect(plugin, updated_plugin);
} break; } break;
case effEditGetRect: { case effEditGetRect: {
@@ -351,7 +352,7 @@ class DispatchDataConverter : public DefaultDataConverter {
return; return;
} }
const auto new_rect = std::get<VstRect>(response.payload); const auto& new_rect = std::get<VstRect>(response.payload);
rect = new_rect; rect = new_rect;
*static_cast<VstRect**>(data) = &rect; *static_cast<VstRect**>(data) = &rect;
@@ -360,7 +361,7 @@ class DispatchDataConverter : public DefaultDataConverter {
// Write the chunk data to some publically accessible place in // Write the chunk data to some publically accessible place in
// `Vst2PluginBridge` and write a pointer to that struct to the // `Vst2PluginBridge` and write a pointer to that struct to the
// data pointer // data pointer
const auto buffer = const auto& buffer =
std::get<ChunkData>(response.payload).buffer; std::get<ChunkData>(response.payload).buffer;
chunk.assign(buffer.begin(), buffer.end()); chunk.assign(buffer.begin(), buffer.end());
@@ -371,21 +372,21 @@ class DispatchDataConverter : public DefaultDataConverter {
// These opcodes pass the plugin some empty struct through the // These opcodes pass the plugin some empty struct through the
// data parameter that the plugin then fills with flags and // data parameter that the plugin then fills with flags and
// other data to describe an input or output channel. // other data to describe an input or output channel.
const auto properties = const auto& properties =
std::get<VstIOProperties>(response.payload); std::get<VstIOProperties>(response.payload);
*static_cast<VstIOProperties*>(data) = properties; *static_cast<VstIOProperties*>(data) = properties;
} break; } break;
case effGetParameterProperties: { case effGetParameterProperties: {
// Same as the above // Same as the above
const auto properties = const auto& properties =
std::get<VstParameterProperties>(response.payload); std::get<VstParameterProperties>(response.payload);
*static_cast<VstParameterProperties*>(data) = properties; *static_cast<VstParameterProperties*>(data) = properties;
} break; } break;
case effGetMidiKeyName: { case effGetMidiKeyName: {
// Ditto // Ditto
const auto properties = const auto& properties =
std::get<VstMidiKeyName>(response.payload); std::get<VstMidiKeyName>(response.payload);
*static_cast<VstMidiKeyName*>(data) = properties; *static_cast<VstMidiKeyName*>(data) = properties;