Clarify the return value override

This commit is contained in:
Robbert van der Helm
2020-03-11 01:12:40 +01:00
parent 5cdfb90a9b
commit 7f2eab476d
3 changed files with 39 additions and 23 deletions
+6 -5
View File
@@ -182,9 +182,7 @@ class DispatchDataConverter : DefaultDataConverter {
}
}
std::optional<intptr_t> write(const int opcode,
void* data,
const EventResult& response) {
void write(const int opcode, void* data, const EventResult& response) {
switch (opcode) {
case effGetChunk:
// Write the chunk data to some publically accessible place in
@@ -194,14 +192,17 @@ class DispatchDataConverter : DefaultDataConverter {
chunk.assign(response.data->begin(), response.data->end());
*static_cast<void**>(data) = chunk.data();
return std::nullopt;
break;
default:
return DefaultDataConverter::write(opcode, data, response);
DefaultDataConverter::write(opcode, data, response);
break;
}
}
intptr_t return_value(const int opcode, const intptr_t original) {
return DefaultDataConverter::return_value(opcode, original);
}
private:
std::vector<uint8_t>& chunk;
};