Rename YaEditController2 to YaEditController

Adding versions to our implementations doesn't work when the versions
and extensions start becoming non-numerical. This is what happened with
`IComponentHandler`.

src/common/serialization/vst3.h

@@ -77,15 +77,15 @@ using ControlRequest = std::variant<Vst3PluginProxy::Construct,
                                     YaComponent::SetActive,
                                     YaConnectionPoint::Connect,
                                     YaConnectionPoint::Disconnect,
-                                    YaEditController2::SetComponentState,
-                                    YaEditController2::GetParameterCount,
-                                    YaEditController2::GetParameterInfo,
-                                    YaEditController2::GetParamStringByValue,
-                                    YaEditController2::GetParamValueByString,
-                                    YaEditController2::NormalizedParamToPlain,
-                                    YaEditController2::PlainParamToNormalized,
-                                    YaEditController2::GetParamNormalized,
-                                    YaEditController2::SetParamNormalized,
+                                    YaEditController::SetComponentState,
+                                    YaEditController::GetParameterCount,
+                                    YaEditController::GetParameterInfo,
+                                    YaEditController::GetParamStringByValue,
+                                    YaEditController::GetParamValueByString,
+                                    YaEditController::NormalizedParamToPlain,
+                                    YaEditController::PlainParamToNormalized,
+                                    YaEditController::GetParamNormalized,
+                                    YaEditController::SetParamNormalized,
                                     YaPluginBase::Initialize,
                                     YaPluginBase::Terminate,
                                     YaPluginFactory::Construct,

src/common/serialization/vst3/plugin-proxy.cpp

@@ -32,7 +32,7 @@ Vst3PluginProxy::Vst3PluginProxy(const ConstructArgs&& args)
     : YaAudioProcessor(std::move(args.audio_processor_args)),
       YaComponent(std::move(args.component_args)),
       YaConnectionPoint(std::move(args.connection_point_args)),
-      YaEditController2(std::move(args.edit_controller_2_args)),
+      YaEditController(std::move(args.edit_controller_2_args)),
       YaPluginBase(std::move(args.plugin_base_args)),
       arguments(std::move(args)){FUNKNOWN_CTOR}
 
@@ -77,11 +77,11 @@ tresult PLUGIN_API Vst3PluginProxy::queryInterface(Steinberg::FIDString _iid,
         QUERY_INTERFACE(_iid, obj, Steinberg::Vst::IConnectionPoint::iid,
                         Steinberg::Vst::IConnectionPoint)
     }
-    if (YaEditController2::supported_version_1()) {
+    if (YaEditController::supported_version_1()) {
         QUERY_INTERFACE(_iid, obj, Steinberg::Vst::IEditController::iid,
                         Steinberg::Vst::IEditController)
     }
-    if (YaEditController2::supported_version_2()) {
+    if (YaEditController::supported_version_2()) {
         QUERY_INTERFACE(_iid, obj, Steinberg::Vst::IEditController2::iid,
                         Steinberg::Vst::IEditController2)
     }

src/common/serialization/vst3/plugin-proxy.h

@@ -57,7 +57,7 @@
 class Vst3PluginProxy : public YaAudioProcessor,
                         public YaComponent,
                         public YaConnectionPoint,
-                        public YaEditController2,
+                        public YaEditController,
                         public YaPluginBase {
    public:
     /**
@@ -80,7 +80,7 @@ class Vst3PluginProxy : public YaAudioProcessor,
         YaAudioProcessor::ConstructArgs audio_processor_args;
         YaComponent::ConstructArgs component_args;
         YaConnectionPoint::ConstructArgs connection_point_args;
-        YaEditController2::ConstructArgs edit_controller_2_args;
+        YaEditController::ConstructArgs edit_controller_2_args;
         YaPluginBase::ConstructArgs plugin_base_args;
 
         template <typename S>

src/common/serialization/vst3/plugin/edit-controller.cpp

@@ -16,14 +16,14 @@
 
 #include "edit-controller.h"
 
-YaEditController2::ConstructArgs::ConstructArgs() {}
+YaEditController::ConstructArgs::ConstructArgs() {}
 
-YaEditController2::ConstructArgs::ConstructArgs(
+YaEditController::ConstructArgs::ConstructArgs(
     Steinberg::IPtr<Steinberg::FUnknown> object)
     : supported_version_1(
           Steinberg::FUnknownPtr<Steinberg::Vst::IEditController>(object)),
       supported_version_2(
           Steinberg::FUnknownPtr<Steinberg::Vst::IEditController2>(object)) {}
 
-YaEditController2::YaEditController2(const ConstructArgs&& args)
+YaEditController::YaEditController(const ConstructArgs&& args)
     : arguments(std::move(args)) {}

src/common/serialization/vst3/plugin/edit-controller.h

@@ -31,11 +31,11 @@
  * Steinberg forgot to inherit `IEditController2` from `IEditController` event
  * if it says it does in the docs, so we'll pretend they just that.
  */
-class YaEditController2 : public Steinberg::Vst::IEditController,
-                          public Steinberg::Vst::IEditController2 {
+class YaEditController : public Steinberg::Vst::IEditController,
+                         public Steinberg::Vst::IEditController2 {
    public:
     /**
-     * These are the arguments for creating a `YaEditController2`.
+     * These are the arguments for creating a `YaEditController`.
      */
     struct ConstructArgs {
         ConstructArgs();
@@ -67,7 +67,7 @@ class YaEditController2 : public Steinberg::Vst::IEditController,
      * Instantiate this instance with arguments read from another interface
      * implementation.
      */
-    YaEditController2(const ConstructArgs&& args);
+    YaEditController(const ConstructArgs&& args);
 
     inline bool supported_version_1() const {
         return arguments.supported_version_1;