Remove Editor::handle_win32_events

This apparently isn't needed anymore.
This commit is contained in:
Robbert van der Helm
2020-12-21 18:24:07 +01:00
parent 0f43e21fc0
commit 7e34cf69fe
4 changed files with 6 additions and 36 deletions
+6 -10
View File
@@ -355,17 +355,13 @@ void Vst2Bridge::handle_x11_events() {
} }
void Vst2Bridge::handle_win32_events() { void Vst2Bridge::handle_win32_events() {
if (editor) { MSG msg;
editor->handle_win32_events();
} else {
MSG msg;
for (int i = 0; i < max_win32_messages && for (int i = 0;
PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE); i < max_win32_messages && PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE);
i++) { i++) {
TranslateMessage(&msg); TranslateMessage(&msg);
DispatchMessage(&msg); DispatchMessage(&msg);
}
} }
} }
-2
View File
@@ -437,8 +437,6 @@ void Vst3Bridge::handle_x11_events() {
} }
void Vst3Bridge::handle_win32_events() { void Vst3Bridge::handle_win32_events() {
// TODO: Remove this function from the `Editor`
MSG msg; MSG msg;
for (int i = 0; for (int i = 0;
-17
View File
@@ -219,23 +219,6 @@ HWND Editor::get_win32_handle() const {
} }
} }
void Editor::handle_win32_events() const {
MSG msg;
// The null value for the second argument is needed to handle interaction
// with child GUI components. So far limiting this to `max_win32_messages`
// messages has only been needed for Waves plugins as they otherwise cause
// an infinite message loop.
// TODO: If the timer is no longer needed, then we can drop this entire
// function
for (int i = 0;
i < max_win32_messages && PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE);
i++) {
TranslateMessage(&msg);
DispatchMessage(&msg);
}
}
void Editor::handle_x11_events() const { void Editor::handle_x11_events() const {
// TODO: Initiating drag-and-drop in Serum _sometimes_ causes the GUI to // TODO: Initiating drag-and-drop in Serum _sometimes_ causes the GUI to
// update while dragging while other times it does not. From all the // update while dragging while other times it does not. From all the
-7
View File
@@ -125,13 +125,6 @@ class Editor {
*/ */
bool supports_ewmh_active_window() const; bool supports_ewmh_active_window() const;
/**
* Pump messages from the editor loop loop until all events are process.
* Must be run from the same thread the GUI was created in because of Win32
* limitations.
*/
void handle_win32_events() const;
/** /**
* Handle X11 events sent to the window our editor is embedded in. * Handle X11 events sent to the window our editor is embedded in.
*/ */