From 7be78a16a30207badaf85a1c0cfa9823628903bc Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Wed, 31 Aug 2022 23:16:48 +0200 Subject: [PATCH] Switch to a CLAP fork to fix Winelib usage This adds missing calling conventions so calling Windows CLAP functions doesn't result in undefined behavior and memory errors: https://github.com/free-audio/clap/issues/153 --- CHANGELOG.md | 7 +++++++ subprojects/clap.wrap | 10 +++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a45ab7b..7979d218 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +TODO: Mention CLAP. Because, you know, kinda important new feature. + ### Fixed - Fixed a minor memory leak in the Wine->X11 drag-and-drop implementation when @@ -22,6 +24,11 @@ Versioning](https://semver.org/spec/v2.0.0.html). - The VST3 dependency is now at tag `v3.7.5_build_44-patched-2`. The only difference is that the version in the `meson.build` file was bumped from 3.7.3 to 3.7.5. +- As of right now (2022-08-31), the new CLAP wrap dependency uses a fork of CLAP + because upstream does not contain calling conventions. + (, + ). Yabridge will build with + upstream CLAP, but using it will result in memory errors. ## [4.0.2] - 2022-06-27 diff --git a/subprojects/clap.wrap b/subprojects/clap.wrap index 4e1d2942..3a291598 100644 --- a/subprojects/clap.wrap +++ b/subprojects/clap.wrap @@ -1,7 +1,11 @@ [wrap-git] -url = https://github.com/free-audio/clap.git -# This is tag 1.1.1 -revision = af1e05ce6487151c6b36003fdb47566dbb50194e +# url = https://github.com/free-audio/clap.git +# # This is tag 1.1.1 +# revision = af1e05ce6487151c6b36003fdb47566dbb50194e +# FIXME: This is a fork that adds calling convention, as it's not possible to +# use CLAP with Winelib bridging otherwise +url = https://github.com/robbert-vdh/clap.git +revision = feature/calling-conventions depth = 1 patch_directory = clap