mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-10 04:30:12 +02:00
Set the audioMasterGetTime flags
Apparently this is a thing, and Ardour is the only DAW that respects them.
This commit is contained in:
@@ -26,6 +26,9 @@ Versioning](https://semver.org/spec/v2.0.0.html).
|
|||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
|
|
||||||
|
- Fixed missing transport information for VST2 plugins in **Ardour**, breaking
|
||||||
|
host sync and LFOs in certain plugins. This was a regression from yabridge
|
||||||
|
3.2.0.
|
||||||
- Fixed _Insert Piz Here_'s _midiLooper_ crashing in **REAPER** when the plugin
|
- Fixed _Insert Piz Here_'s _midiLooper_ crashing in **REAPER** when the plugin
|
||||||
tries to use REAPER's [host function
|
tries to use REAPER's [host function
|
||||||
API](https://www.reaper.fm/sdk/vst/vst_ext.php#vst_host) which currently isn't
|
API](https://www.reaper.fm/sdk/vst/vst_ext.php#vst_host) which currently isn't
|
||||||
|
|||||||
@@ -619,9 +619,14 @@ void Vst2PluginBridge::do_process(T** inputs, T** outputs, int sample_frames) {
|
|||||||
|
|
||||||
// To prevent unnecessary bridging overhead, we'll send the time information
|
// To prevent unnecessary bridging overhead, we'll send the time information
|
||||||
// together with the buffers because basically every plugin needs this
|
// together with the buffers because basically every plugin needs this
|
||||||
|
// NOTE: Apparently the value parameter here is a bitfield controlling which
|
||||||
|
// for which transport information gets populated, and Ardour is the
|
||||||
|
// only DAW that uses this. Since those flags aren't part of the
|
||||||
|
// VeSTige headers, let's just set all of them!
|
||||||
const VstTimeInfo* returned_time_info =
|
const VstTimeInfo* returned_time_info =
|
||||||
reinterpret_cast<const VstTimeInfo*>(host_callback_function(
|
reinterpret_cast<const VstTimeInfo*>(
|
||||||
&plugin, audioMasterGetTime, 0, 0, nullptr, 0.0));
|
host_callback_function(&plugin, audioMasterGetTime, 0,
|
||||||
|
~static_cast<intptr_t>(0), nullptr, 0.0));
|
||||||
if (returned_time_info) {
|
if (returned_time_info) {
|
||||||
request.current_time_info = *returned_time_info;
|
request.current_time_info = *returned_time_info;
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
Reference in New Issue
Block a user