vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update comments on get_plugin_factory()

Browse Source 
Now that we do use a smart pointer to manage it ourselves, as proven
necessary by REAPER.
This commit is contained in:
Robbert van der Helm
2021-01-21 02:05:21 +01:00
parent 74dc8225d1
commit 6f5a8e3ebf
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin/bridges/vst3.cpp
+2 -2
View File
@@ -369,8 +369,8 @@ Steinberg::IPluginFactory* Vst3PluginBridge::get_plugin_factory() {
new YaPluginFactoryImpl(*this, std::move(factory_args))); new YaPluginFactoryImpl(*this, std::move(factory_args)));
} }
// Because we're returning a raw pointer, we have to increas the // Because we're returning a raw pointer, we have to increase the reference
// reference count ourselves // count ourselves
plugin_factory->addRef(); plugin_factory->addRef();
return plugin_factory; return plugin_factory;
src/plugin/bridges/vst3.h
+3 -3
View File
@@ -63,9 +63,9 @@ class Vst3PluginBridge : PluginBridge<Vst3Sockets<std::jthread>> {
/** /**
* When the host loads the module it will call `GetPluginFactory()` which * When the host loads the module it will call `GetPluginFactory()` which
* will in turn call this function. The idea is that we return an * will in turn call this function. The idea is that we return an
* `IPluginFactory*` while doing all the reference counting that `IPtr<T>` * `IPluginFactory*` that acts as an owned `IPtr<IPluginFactory>`, so we
* would normally do for us ourselves. This means that when the host frees * have to manually increase the reference count here for every plugin
* its last instance of this factory, `plugin_factory` will also be cleared. * factory instance we return.
* *
* @see plugin_factory * @see plugin_factory
*/ */