Remove the editor_coordinate_hack option

I'm not sure if this would still be necessary with the new embedding
approach, but it definitely does cause more problems than it solves.
This commit is contained in:
Robbert van der Helm
2025-03-01 19:17:29 +01:00
parent 51e4d61004
commit 66840d4d16
7 changed files with 4 additions and 51 deletions
-6
View File
@@ -97,12 +97,6 @@ Configuration::Configuration(const fs::path& config_path,
} else {
invalid_options.emplace_back(key);
}
} else if (key == "editor_coordinate_hack") {
if (const auto parsed_value = value.as_boolean()) {
editor_coordinate_hack = parsed_value->get();
} else {
invalid_options.emplace_back(key);
}
} else if (key == "editor_disable_host_scaling") {
if (const auto parsed_value = value.as_boolean()) {
editor_disable_host_scaling = parsed_value->get();
-13
View File
@@ -91,18 +91,6 @@ class Configuration {
*/
std::optional<ghc::filesystem::path> disable_pipes;
/**
* If this is set to `true`, then the after every resize we will move the
* embedded Wine window back to `(0, 0)` and then do the coordinate fixing
* trick again. This may be useful with buggy plugins that draw their GUI
* based on the (top level) window's position. Otherwise those GUIs will be
* offset by the window's actual position on screen. The only plugins I've
* encountered where this was necessary were PSPaudioware E27 and Soundtoys
* Crystallizer. This is not enabled by default, because it also interferes
* with resize handles.
*/
bool editor_coordinate_hack = false;
/**
* If set to `true`, we'll remove the `XdndAware` property all ancestor
* windows in `editor.cpp`. This is needed for REAPER as REAPER implements
@@ -189,7 +177,6 @@ class Configuration {
s.ext(disable_pipes, bitsery::ext::InPlaceOptional(),
[](S& s, auto& v) { s.ext(v, bitsery::ext::GhcPath{}); });
s.value1b(editor_coordinate_hack);
s.value1b(editor_force_dnd);
s.ext(frame_rate, bitsery::ext::InPlaceOptional(),
[](S& s, auto& v) { s.value4b(v); });