From 637176541d9b63c9eb2b75609b66f984da53eaf3 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Wed, 8 Jun 2022 14:57:16 +0200 Subject: [PATCH] Remove old TODOs --- .../serialization/vst3/host-context/plug-interface-support.h | 3 --- tools/yabridgectl/src/actions.rs | 5 ----- 2 files changed, 8 deletions(-) diff --git a/src/common/serialization/vst3/host-context/plug-interface-support.h b/src/common/serialization/vst3/host-context/plug-interface-support.h index e2edcd24..37e3abe1 100644 --- a/src/common/serialization/vst3/host-context/plug-interface-support.h +++ b/src/common/serialization/vst3/host-context/plug-interface-support.h @@ -79,9 +79,6 @@ class YaPlugInterfaceSupport : public Steinberg::Vst::IPlugInterfaceSupport { */ std::optional owner_instance_id; - // TODO: Figure out if we should translate the UIDs from Windows COM to - // non-Windows COM here. I have not actually seen this interface - // used. WineUID iid; template diff --git a/tools/yabridgectl/src/actions.rs b/tools/yabridgectl/src/actions.rs index 2fa478ac..848bc867 100644 --- a/tools/yabridgectl/src/actions.rs +++ b/tools/yabridgectl/src/actions.rs @@ -454,11 +454,6 @@ pub fn do_sync(config: &mut Config, options: &SyncOptions) -> Result<()> { // screenshots and documentation // TODO: Also symlink presets, but this is a bit more involved. See // https://developer.steinberg.help/display/VST/Preset+Locations - // TODO: Also handle `moduleinfo.json` files. That would require translating the - // UIDs from the COM-format to the non-COM format. Yabridge currently does - // not suport this because supporting the accompanying - // `IPluginCompatibility` would require having to add a JSON parser to - // yabridge just for that. if let Some(original_resources_dir) = module.original_resources_dir() { let target_resources_dir = module.target_resources_dir();