mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-07 12:10:09 +02:00
Explicitly list opcodes that should return strings
The automatic detection works fine in every case I've tested other than Fabfilter plugins, but this is probably for the best.
This commit is contained in:
@@ -241,6 +241,21 @@ class DispatchDataConverter : DefaultDataConverter {
|
||||
break;
|
||||
case effGetMidiKeyName:
|
||||
return *static_cast<const VstMidiKeyName*>(data);
|
||||
// Any VST host I've encountered has properly zeroed out these their
|
||||
// string buffers, but we'll add a list of opcodes that should
|
||||
// return a string just in case `DefaultDataConverter::read()` can't
|
||||
// figure it out.
|
||||
case effGetProgramName:
|
||||
case effGetParamLabel:
|
||||
case effGetParamDisplay:
|
||||
case effGetParamName:
|
||||
case effGetProgramNameIndexed:
|
||||
case effGetEffectName:
|
||||
case effGetVendorString:
|
||||
case effGetProductString:
|
||||
case effShellGetNextPlugin:
|
||||
return WantsString{};
|
||||
break;
|
||||
default:
|
||||
return DefaultDataConverter::read(opcode, index, value, data);
|
||||
break;
|
||||
|
||||
Reference in New Issue
Block a user