From 6073d812a5e074829e18992d65468dc3fb713d33 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 21 Aug 2020 16:43:49 +0200 Subject: [PATCH] Clarify the issue in REAPER It's caused by mutual recursion which at the moment does not work with yabridge's communication model. --- README.md | 7 ++++--- src/wine-host/bridges/vst2.cpp | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 47402163..362498b3 100644 --- a/README.md +++ b/README.md @@ -402,9 +402,10 @@ some additional dependencies for their GUIs to work correctly. Notable examples include: - **REAPER** and **Renoise** can both freeze when using plugins that call the - `audioMasterUpdateDisplay()` function. Until REAPER and Renoise fix this issue - you can set an [option](#miscellaneous-fixes-and-workarounds) through - `yabridge.toml` to work around this. + `audioMasterUpdateDisplay()` function because of mutual recursion limitations. + Until this is fixed you can set an + [option](#miscellaneous-fixes-and-workarounds) through `yabridge.toml` to work + around this. - **Native Instruments** plugins work, but Native Access is unable to finish installing the plugins. To work around this you can open the .iso file downloaded to your downloads directory and run the installer directly. When diff --git a/src/wine-host/bridges/vst2.cpp b/src/wine-host/bridges/vst2.cpp index 4a680d2d..44127ee6 100644 --- a/src/wine-host/bridges/vst2.cpp +++ b/src/wine-host/bridges/vst2.cpp @@ -523,8 +523,8 @@ intptr_t Vst2Bridge::host_callback(AEffect* effect, intptr_t value, void* data, float option) { - // HACK: Sadly this is needed to work around a timing issue with REAPER and - // Renoise. See #29 and #32. + // HACK: Sadly this is needed to work around a mutual recursion issue with + // REAPER and Renoise. See #29 and #32. // TODO: We don't have access to the verbosity level here, but it would be // nice to log that this is being skipped when `YABRIDGE_DEBUG_LEVEL // >= 2`.