From 602bbc5d353fffa99d056510f9ba3819bc76b36e Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Thu, 17 Dec 2020 00:31:01 +0100 Subject: [PATCH] Add TODO about replacing known_iids with flags --- docs/vst3.md | 3 +++ src/common/serialization/vst3/plugin-factory.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/docs/vst3.md b/docs/vst3.md index 11253864..a5ef5413 100644 --- a/docs/vst3.md +++ b/docs/vst3.md @@ -4,6 +4,9 @@ TODO: Flesh this out further TODO: Link to `src/common/serialization/vst3/README.md` +TODO: Mention the new `Ya::supports()` mechanism for monolithic interfaces +through multiple inheritance + The VST3 SDK uses an architecture where every concrete object inherits from an interface, and every interface inherits from `FUnknown`. `FUnkonwn` offers a dynamic casting interface through `queryInterface()` and a reference counting diff --git a/src/common/serialization/vst3/plugin-factory.h b/src/common/serialization/vst3/plugin-factory.h index 6d1dfa35..933f0bf8 100644 --- a/src/common/serialization/vst3/plugin-factory.h +++ b/src/common/serialization/vst3/plugin-factory.h @@ -54,6 +54,9 @@ class YaPluginFactory : public Steinberg::IPluginFactory3 { /** * The IIDs that the interface we serialized supports. + * + * TODO: Replace this with a set of boolean flags, just like we're doing + * with the other interfaces. */ std::set known_iids;