From 555b442f75bc7bc1bf5a95d9ffe51da5d80a7364 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Mon, 30 Nov 2020 16:49:51 +0100 Subject: [PATCH] Add a todo regarding benchmarking ad hoc sockets --- src/common/communication/vst2.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/common/communication/vst2.h b/src/common/communication/vst2.h index 9706688c..bdf9f934 100644 --- a/src/common/communication/vst2.h +++ b/src/common/communication/vst2.h @@ -230,6 +230,10 @@ class EventHandler { // another thread, then we'll spawn a new socket to handle the request. EventResult response; { + // XXX: Maybe at some point we should benchmark how often this + // ad hoc socket spawning mechanism gets used. If some hosts + // for instance consistently and repeatedly trigger this then + // we might be able to do some optimizations there. std::unique_lock lock(write_mutex, std::try_to_lock); if (lock.owns_lock()) { write_object(socket, event);