Remove the editor_xembed option

src/wine-host/editor.h

@@ -126,6 +126,9 @@ class DeferredWin32Window {
 };
 
 /**
+ * TODO: This documentation needs to be updated with the recent changes to how
+ *       embedding is handled.
+ *
  * A wrapper around the win32 windowing API to create and destroy editor
  * windows. We can embed this window into the window provided by the host, and a
  * VST plugin can then later embed itself in the window create here.
@@ -202,8 +205,8 @@ class Editor {
 
     /**
      * Show the window, should be called after the plugin has embedded itself.
-     * There's absolutely zero reason why this can't be done in the constructor
-     * or in `do_xembed()`, but it needs to be. Thanks Waves.
+     * There's absolutely zero reason why this can't be done in the constructor,
+     * but it can't be. Thanks Waves.
      */
     void show() noexcept;
 
@@ -277,12 +280,6 @@ class Editor {
      */
     const bool use_force_dnd_;
 
-    /**
-     * Whether to use XEmbed instead of yabridge's normal window embedded. Wine
-     * with XEmbed tends to cause rendering issues, so it's disabled by default.
-     */
-    const bool use_xembed_;
-
    private:
     /**
      * Get the X11 event mask containing the current keyboard modifiers. Because
@@ -320,29 +317,11 @@ class Editor {
      */
     void redetect_host_window() noexcept;
 
-    /**
-     * Send an XEmbed message to a window. This does not include a flush. See
-     * the spec for more information:
-     *
-     * https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html#lifecycle
-     */
-    void send_xembed_message(xcb_window_t window,
-                             uint32_t message,
-                             uint32_t detail,
-                             uint32_t data1,
-                             uint32_t data2) const noexcept;
-
     /**
      * Reparent `child` to `new_parent`. This includes the flush.
      */
     void do_reparent(xcb_window_t child, xcb_window_t new_parent) const;
 
-    /**
-     * Start the XEmbed procedure when `use_xembed_` is enabled. This should be
-     * rerun whenever visibility changes.
-     */
-    void do_xembed() const;
-
     /**
      * The logger instance we will print debug tracing information to.
      */
@@ -449,9 +428,4 @@ class Editor {
      * `supports_ewmh_active_window()`.
      */
     mutable std::optional<bool> supports_ewmh_active_window_cache_;
-
-    /**
-     * The atom corresponding to `_XEMBED`.
-     */
-    xcb_atom_t xcb_xembed_message_;
 };