From 4fdd50d1a3c18dec986f1f9050f0906047b9e12d Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Sun, 10 Jan 2021 17:34:42 +0100 Subject: [PATCH] Relax assertions in stream reading Reading 0 bytes in Bitwig will return kResultFalse. --- src/common/serialization/vst3/bstream.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/common/serialization/vst3/bstream.cpp b/src/common/serialization/vst3/bstream.cpp index e93801ef..3f054662 100644 --- a/src/common/serialization/vst3/bstream.cpp +++ b/src/common/serialization/vst3/bstream.cpp @@ -69,8 +69,9 @@ YaBStream::YaBStream(Steinberg::IBStream* stream) { assert( stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet) == Steinberg::kResultOk); - assert(stream->read(buffer.data(), size, &num_bytes_read) == - Steinberg::kResultOk); + + // Reading zero bytes will return `kResultFalse` in some implementations + stream->read(buffer.data(), size, &num_bytes_read); assert(num_bytes_read == 0 || num_bytes_read == size); }