From 4e99afd53de28c0910a21c0d8311f8c0a38f4c04 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Thu, 14 Apr 2022 23:44:30 +0200 Subject: [PATCH] Add a note on case sensitive extension matching --- src/plugin/utils.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/plugin/utils.cpp b/src/plugin/utils.cpp index 840842d8..af4a6ec5 100644 --- a/src/plugin/utils.cpp +++ b/src/plugin/utils.cpp @@ -132,6 +132,11 @@ std::string PluginInfo::wine_version() const { fs::path find_plugin_library(const fs::path& this_plugin_path, PluginType plugin_type, bool prefer_32bit_vst3) { + // TODO: We only consider lower case extensions, and yabridgectl also + // explicitly ignores upper and mixed case versions. Doing a case + // insensitive version of this would involve checking each entry in + // the directory listing. That's possible, but not something we're + // doing right now. switch (plugin_type) { case PluginType::vst2: { fs::path plugin_path(this_plugin_path);