From 4a7b560972e46f7b948cb7cd66379e8f3fa72950 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Sat, 2 Jan 2021 19:32:28 +0100 Subject: [PATCH] Revert "Add a background brush to the window" While this does get rid of artifacts, it can also add a brief moment where the gray background becomes visible when the window reconfigures which can look jarring. This reverts commit 35c71383337e71653caf482b357db0f2433f6547. --- CHANGELOG.md | 5 ----- meson.build | 3 --- src/wine-host/editor.cpp | 1 - 3 files changed, 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74965a54..c2b39fa1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,11 +54,6 @@ TODO: Add an updated screenshot with some fancy VST3-only plugins to the readme with, and it then applies the change conditionally to be able to support building with both older and newer versions of Wine. -### Fixed - -- Added a background to the editor window to get rid of artifacts that would - occur if the plugin or the host didn't resize the window correctly. - ### yabridgectl - Updated for the changes in yabridge 3.0. Yabridgectl now allows you to set up diff --git a/meson.build b/meson.build index ca0a5dbd..281e08bb 100644 --- a/meson.build +++ b/meson.build @@ -214,7 +214,6 @@ bitsery_dep = subproject('bitsery', version : '5.2.0').get_variable('bitsery_dep function2_dep = subproject('function2', version : '4.1.0').get_variable('function2_dep') threads_dep = dependency('threads') tomlplusplus_dep = subproject('tomlplusplus', version : '2.1.0').get_variable('tomlplusplus_dep') -wine_gdi32_dep = declare_dependency(link_args : '-lgdi32') # The built in threads dependency does not know how to handle winegcc wine_threads_dep = declare_dependency(link_args : '-lpthread') xcb_dep = dependency('xcb') @@ -404,7 +403,6 @@ host_64bit_deps = [ bitsery_dep, function2_dep, tomlplusplus_dep, - wine_gdi32_dep, wine_threads_dep, xcb_dep, ] @@ -451,7 +449,6 @@ if with_bitbridge bitsery_dep, function2_dep, tomlplusplus_dep, - wine_gdi32_dep, wine_threads_dep, xcb_32bit_dep, ] diff --git a/src/wine-host/editor.cpp b/src/wine-host/editor.cpp index 6299be40..afce15b9 100644 --- a/src/wine-host/editor.cpp +++ b/src/wine-host/editor.cpp @@ -682,7 +682,6 @@ ATOM register_window_class(std::string window_class_name) { window_class.lpfnWndProc = window_proc; window_class.hInstance = GetModuleHandle(nullptr); window_class.hCursor = LoadCursor(nullptr, IDC_ARROW); - window_class.hbrBackground = CreateSolidBrush(RGB(32, 32, 32)); window_class.lpszClassName = window_class_name.c_str(); return RegisterClassEx(&window_class);