Fix some of the clang-tidy lints

This commit is contained in:
Robbert van der Helm
2021-04-14 16:09:46 +02:00
parent 8942727661
commit 4937010557
13 changed files with 40 additions and 24 deletions
@@ -48,7 +48,7 @@ size_t Vst3PluginProxyImpl::register_context_menu(
std::lock_guard lock(context_menus_mutex);
const size_t context_menu_id = current_context_menu_id.fetch_add(1);
context_menus.emplace(context_menu_id, std::move(menu));
context_menus.emplace(context_menu_id, menu);
return context_menu_id;
}
+1 -1
View File
@@ -144,7 +144,7 @@ Vst3PluginBridge::Vst3PluginBridge()
const size_t context_menu_id =
plugin_proxies.at(request.owner_instance_id)
.get()
.register_context_menu(std::move(context_menu));
.register_context_menu(context_menu);
return YaComponentHandler3::CreateContextMenuResponse{
.context_menu_args =
+1
View File
@@ -163,6 +163,7 @@ fs::path find_plugin_library(const fs::path& this_plugin_path,
// _actual_ (with yabridgectl `x86_64-win` should only contain a
// 64-bit plugin and `x86-win` should only contain a 32-bit plugin,
// but you never know!)
// NOLINTNEXTLINE(bugprone-branch-clone)
if (prefer_32bit_vst3 && fs::exists(candidate_path_32bit)) {
return fs::canonical(candidate_path_32bit);
} else if (fs::exists(candidate_path_64bit)) {
+1
View File
@@ -24,6 +24,7 @@
// as close to the vanilla SDK as possible.
#define InitModule init_module
#define DeinitModule deinit_module
// NOLINTNEXTLINE(bugprone-suspicious-include)
#include <public.sdk/source/main/linuxmain.cpp>
// Because VST3 plugins consist of completely independent components that have