Fix some of the clang-tidy lints

This commit is contained in:
Robbert van der Helm
2021-04-14 16:09:46 +02:00
parent 8942727661
commit 4937010557
13 changed files with 40 additions and 24 deletions
+5 -3
View File
@@ -36,14 +36,16 @@ VstEvents& DynamicVstEvents::as_c_events() {
// number of events minus one pointers.
static_assert(std::extent_v<decltype(VstEvents::events)> == 1);
const size_t buffer_size =
sizeof(VstEvents) + ((events.size() - 1) * sizeof(VstEvent*));
sizeof(VstEvents) +
((events.size() - 1) *
sizeof(VstEvent*)); // NOLINT(bugprone-sizeof-expression)
vst_events_buffer.resize(buffer_size);
// Now we can populate the VLA with pointers to the objects in the `events`
// vector
VstEvents* vst_events =
reinterpret_cast<VstEvents*>(vst_events_buffer.data());
vst_events->numEvents = events.size();
vst_events->numEvents = static_cast<int>(events.size());
std::transform(events.begin(), events.end(), vst_events->events,
[](VstEvent& event) -> VstEvent* { return &event; });
@@ -76,7 +78,7 @@ VstSpeakerArrangement& DynamicSpeakerArrangement::as_c_speaker_arrangement() {
reinterpret_cast<VstSpeakerArrangement*>(
speaker_arrangement_buffer.data());
speaker_arrangement->flags = flags;
speaker_arrangement->num_speakers = speakers.size();
speaker_arrangement->num_speakers = static_cast<int>(speakers.size());
std::copy(speakers.begin(), speakers.end(), speaker_arrangement->speakers);
return *speaker_arrangement;