vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-15 13:00:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix some of the clang-tidy lints

Browse Source
This commit is contained in:
Robbert van der Helm
2021-04-14 16:09:46 +02:00
parent 8942727661
commit 4937010557
13 changed files with 40 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst2.cpp
+5 -3
View File
@@ -36,14 +36,16 @@ VstEvents& DynamicVstEvents::as_c_events() {
// number of events minus one pointers.
static_assert(std::extent_v<decltype(VstEvents::events)> == 1);
const size_t buffer_size =
sizeof(VstEvents) + ((events.size() - 1) * sizeof(VstEvent*));
sizeof(VstEvents) +
((events.size() - 1) *
sizeof(VstEvent*)); // NOLINT(bugprone-sizeof-expression)
vst_events_buffer.resize(buffer_size);
// Now we can populate the VLA with pointers to the objects in the `events`
// vector
VstEvents* vst_events =
reinterpret_cast<VstEvents*>(vst_events_buffer.data());
vst_events->numEvents = events.size();
vst_events->numEvents = static_cast<int>(events.size());
std::transform(events.begin(), events.end(), vst_events->events,
[](VstEvent& event) -> VstEvent* { return &event; });
@@ -76,7 +78,7 @@ VstSpeakerArrangement& DynamicSpeakerArrangement::as_c_speaker_arrangement() {
reinterpret_cast<VstSpeakerArrangement*>(
speaker_arrangement_buffer.data());
speaker_arrangement->flags = flags;
speaker_arrangement->num_speakers = speakers.size();
speaker_arrangement->num_speakers = static_cast<int>(speakers.size());
std::copy(speakers.begin(), speakers.end(), speaker_arrangement->speakers);
return *speaker_arrangement;
src/common/serialization/vst3/bstream.cpp
+9 -7
View File
@@ -40,7 +40,8 @@ YaBStream::YaBStream(Steinberg::IBStream* stream) {
int32 num_bytes_read = 0;
buffer.resize(size);
stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);
stream->read(buffer.data(), size, &num_bytes_read);
stream->read(buffer.data(), static_cast<int32>(size),
&num_bytes_read);
assert(num_bytes_read == 0 || num_bytes_read == size);
}
}
@@ -103,7 +104,8 @@ tresult YaBStream::write_back(Steinberg::IBStream* stream) const {
// A `stream->seek(0, kIBSeekSet)` breaks restoring states in Bitwig. Not
// sure if Bitwig is prepending a header or if this is expected behaviour.
int32 num_bytes_written = 0;
if (stream->write(const_cast<uint8_t*>(buffer.data()), buffer.size(),
if (stream->write(const_cast<uint8_t*>(buffer.data()),
static_cast<int32>(buffer.size()),
&num_bytes_written) == Steinberg::kResultOk) {
// Some implementations will return `kResultFalse` when writing 0 bytes
assert(num_bytes_written == 0 ||
@@ -145,7 +147,7 @@ tresult PLUGIN_API YaBStream::read(void* buffer,
seek_position += bytes_to_read;
if (numBytesRead) {
*numBytesRead = bytes_to_read;
*numBytesRead = static_cast<int32>(bytes_to_read);
}
return Steinberg::kResultOk;
@@ -163,7 +165,7 @@ tresult PLUGIN_API YaBStream::write(void* buffer,
}
std::copy_n(reinterpret_cast<uint8_t*>(buffer), numBytes,
this->buffer.begin() + seek_position);
this->buffer.begin() + static_cast<int>(seek_position));
seek_position += numBytes;
if (numBytesWritten) {
@@ -190,7 +192,7 @@ tresult PLUGIN_API YaBStream::seek(int64 pos, int32 mode, int64* result) {
}
if (result) {
*result = seek_position;
*result = static_cast<int64>(seek_position);
}
return Steinberg::kResultOk;
@@ -198,7 +200,7 @@ tresult PLUGIN_API YaBStream::seek(int64 pos, int32 mode, int64* result) {
tresult PLUGIN_API YaBStream::tell(int64* pos) {
if (pos) {
*pos = seek_position;
*pos = static_cast<int64>(seek_position);
return Steinberg::kResultOk;
} else {
return Steinberg::kInvalidArgument;
@@ -206,7 +208,7 @@ tresult PLUGIN_API YaBStream::tell(int64* pos) {
}
tresult PLUGIN_API YaBStream::getStreamSize(int64& size) {
size = seek_position;
size = static_cast<int64>(seek_position);
return Steinberg::kResultOk;
}
src/common/serialization/vst3/event-list.cpp
+5 -3
View File
@@ -215,7 +215,7 @@ IMPLEMENT_FUNKNOWN_METHODS(YaEventList,
#pragma GCC diagnostic pop
int32 PLUGIN_API YaEventList::getEventCount() {
return events.size();
return static_cast<int32>(events.size());
}
tresult PLUGIN_API YaEventList::getEvent(int32 index,
@@ -231,8 +231,10 @@ tresult PLUGIN_API YaEventList::getEvent(int32 index,
if (index >= static_cast<int32>(num_already_reconstructed_events)) {
reconstructed_events.resize(events.size());
std::transform(
events.begin() + num_already_reconstructed_events, events.end(),
reconstructed_events.begin() + num_already_reconstructed_events,
events.begin() + static_cast<int>(num_already_reconstructed_events),
events.end(),
reconstructed_events.begin() +
static_cast<int>(num_already_reconstructed_events),
[](const YaEvent& event) { return event.get(); });
}
src/common/serialization/vst3/param-value-queue.cpp
+2 -2
View File
@@ -62,7 +62,7 @@ Steinberg::Vst::ParamID PLUGIN_API YaParamValueQueue::getParameterId() {
}
int32 PLUGIN_API YaParamValueQueue::getPointCount() {
return queue.size();
return static_cast<int32>(queue.size());
}
tresult PLUGIN_API
@@ -81,7 +81,7 @@ YaParamValueQueue::getPoint(int32 index,
tresult PLUGIN_API YaParamValueQueue::addPoint(int32 sampleOffset,
Steinberg::Vst::ParamValue value,
int32& index /*out*/) {
index = queue.size();
index = static_cast<int32>(queue.size());
queue.push_back({sampleOffset, value});
return Steinberg::kResultOk;
src/common/serialization/vst3/parameter-changes.cpp
+2 -2
View File
@@ -59,7 +59,7 @@ void YaParameterChanges::write_back_outputs(
}
int32 PLUGIN_API YaParameterChanges::getParameterCount() {
return queues.size();
return static_cast<int32>(queues.size());
}
Steinberg::Vst::IParamValueQueue* PLUGIN_API
@@ -74,7 +74,7 @@ YaParameterChanges::getParameterData(int32 index) {
Steinberg::Vst::IParamValueQueue* PLUGIN_API
YaParameterChanges::addParameterData(const Steinberg::Vst::ParamID& id,
int32& index /*out*/) {
index = queues.size();
index = static_cast<int32>(queues.size());
queues.push_back(YaParamValueQueue(id));
return &queues[index];
src/common/serialization/vst3/process-data.cpp
+7 -4
View File
@@ -72,7 +72,8 @@ Steinberg::Vst::AudioBusBuffers YaAudioBusBuffers::get() {
buffer_pointers.push_back(buffer.data());
}
reconstructed_buffers.numChannels = buffers.size();
reconstructed_buffers.numChannels =
static_cast<int32>(buffers.size());
reconstructed_buffers.channelBuffers64 =
reinterpret_cast<double**>(buffer_pointers.data());
},
@@ -82,7 +83,8 @@ Steinberg::Vst::AudioBusBuffers YaAudioBusBuffers::get() {
buffer_pointers.push_back(buffer.data());
}
reconstructed_buffers.numChannels = buffers.size();
reconstructed_buffers.numChannels =
static_cast<int32>(buffers.size());
reconstructed_buffers.channelBuffers32 =
reinterpret_cast<float**>(buffer_pointers.data());
},
@@ -194,8 +196,9 @@ Steinberg::Vst::ProcessData& YaProcessData::get() {
reconstructed_process_data.processMode = process_mode;
reconstructed_process_data.symbolicSampleSize = symbolic_sample_size;
reconstructed_process_data.numSamples = num_samples;
reconstructed_process_data.numInputs = inputs.size();
reconstructed_process_data.numOutputs = outputs_num_channels.size();
reconstructed_process_data.numInputs = static_cast<int32>(inputs.size());
reconstructed_process_data.numOutputs =
static_cast<int32>(outputs_num_channels.size());
reconstructed_process_data.inputs = inputs_audio_bus_buffers.data();
reconstructed_process_data.outputs = outputs_audio_bus_buffers.data();