mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-07 03:50:11 +02:00
Revert "[yabridgectl] Don't resolve rvas when parsing"
This reverts commit 6c1f7bd469.
Somehow disabling this option seems to cause goblin to deadlock when
scanning at least one plugin.
This commit is contained in:
@@ -46,12 +46,7 @@ fn parse_pe32_goblin<P: AsRef<Path>>(binary: P) -> Result<Pe32Info> {
|
|||||||
// The original version of this function also supports ELF and Mach architectures, but we don't
|
// The original version of this function also supports ELF and Mach architectures, but we don't
|
||||||
// need those things here
|
// need those things here
|
||||||
let bytes = util::read(&binary)?;
|
let bytes = util::read(&binary)?;
|
||||||
let obj = goblin::pe::PE::parse_with_opts(
|
let obj = goblin::pe::PE::parse(&bytes).with_context(|| {
|
||||||
&bytes,
|
|
||||||
// We only care about the exports
|
|
||||||
&goblin::pe::options::ParseOptions { resolve_rva: false },
|
|
||||||
)
|
|
||||||
.with_context(|| {
|
|
||||||
format!(
|
format!(
|
||||||
"Could not parse '{}' as a PE32(+) binary",
|
"Could not parse '{}' as a PE32(+) binary",
|
||||||
binary.as_ref().display()
|
binary.as_ref().display()
|
||||||
|
|||||||
Reference in New Issue
Block a user