Move communication.h to communication/vst2.h

meson.build

@@ -103,15 +103,15 @@ include_dir = include_directories('src/include')
 shared_library(
   'yabridge-vst2',
   [
+    'src/common/communication/vst2.cpp',
+    'src/common/serialization/vst2.cpp',
     'src/common/configuration.cpp',
     'src/common/logging.cpp',
-    'src/common/serialization/vst2.cpp',
-    'src/common/communication.cpp',
     'src/common/utils.cpp',
-    'src/plugin/host-process.cpp',
-    'src/plugin/vst2-plugin.cpp',
     'src/plugin/bridges/vst2.cpp',
+    'src/plugin/host-process.cpp',
     'src/plugin/utils.cpp',
+    'src/plugin/vst2-plugin.cpp',
     version_header,
   ],
   native : true,
@@ -128,10 +128,10 @@ shared_library(
 )
 
 host_sources = [
+  'src/common/communication/vst2.cpp',
+  'src/common/serialization/vst2.cpp',
   'src/common/configuration.cpp',
   'src/common/logging.cpp',
-  'src/common/serialization/vst2.cpp',
-  'src/common/communication.cpp',
   'src/common/utils.cpp',
   'src/wine-host/bridges/vst2.cpp',
   'src/wine-host/editor.cpp',

src/common/communication/vst2.cpp

@@ -14,11 +14,11 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
-#include "communication.h"
+#include "vst2.h"
 
 #include <random>
 
-#include "utils.h"
+#include "../utils.h"
 
 namespace fs = boost::filesystem;
 

src/common/communication/vst2.h

@@ -30,7 +30,7 @@
 #include <boost/asio/write.hpp>
 #include <boost/filesystem.hpp>
 
-#include "logging.h"
+#include "../logging.h"
 
 template <typename B>
 using OutputAdapter = bitsery::OutputBufferAdapter<B>;

src/common/logging.h

@@ -20,6 +20,8 @@
 #include <optional>
 #include <ostream>
 
+// TODO: Split up the plugin API specific logging functions so we don't have to
+//       include a bunch of stuff we don't need
 #include "serialization/vst2.h"
 
 /**

src/plugin/bridges/vst2.cpp

@@ -20,7 +20,7 @@
 #include <src/common/config/config.h>
 #include <src/common/config/version.h>
 
-#include "../../common/communication.h"
+#include "../../common/communication/vst2.h"
 #include "../../common/utils.h"
 #include "../utils.h"
 

src/plugin/bridges/vst2.h

@@ -23,7 +23,7 @@
 #include <mutex>
 #include <thread>
 
-#include "../../common/communication.h"
+#include "../../common/communication/vst2.h"
 #include "../../common/configuration.h"
 #include "../../common/logging.h"
 #include "../host-process.h"

src/plugin/host-process.cpp

@@ -21,7 +21,7 @@
 #include <boost/process/io.hpp>
 #include <boost/process/start_dir.hpp>
 
-#include "../common/communication.h"
+#include "../common/communication/vst2.h"
 
 namespace bp = boost::process;
 namespace fs = boost::filesystem;

src/plugin/host-process.h

@@ -25,7 +25,7 @@
 #include <boost/process/child.hpp>
 #include <thread>
 
-#include "../common/communication.h"
+#include "../common/communication/vst2.h"
 #include "../common/logging.h"
 #include "utils.h"
 

src/wine-host/bridges/group.cpp

@@ -21,7 +21,9 @@
 #include <boost/process/environment.hpp>
 #include <regex>
 
-#include "../../common/communication.h"
+// TODO: Change this to commucation/common.h after refactoring, and do the same
+//       thing in other places where we don't need everything from VST2
+#include "../../common/communication/vst2.h"
 
 // FIXME: `std::filesystem` is broken in wineg++, at least under Wine 5.8. Any
 //        path operation will thrown an encoding related error

src/wine-host/bridges/vst2.cpp

@@ -21,7 +21,7 @@
 #include <iostream>
 #include <set>
 
-#include "../../common/communication.h"
+#include "../../common/communication/vst2.h"
 
 /**
  * A function pointer to what should be the entry point of a VST plugin.

src/wine-host/bridges/vst2.h

@@ -29,7 +29,7 @@
 #include <boost/asio/local/stream_protocol.hpp>
 #include <mutex>
 
-#include "../../common/communication.h"
+#include "../../common/communication/vst2.h"
 #include "../../common/configuration.h"
 #include "../../common/logging.h"
 #include "../editor.h"