mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-16 05:33:07 +02:00
Change wording
This commit is contained in:
@@ -57,8 +57,8 @@ Vst2Bridge* current_bridge_instance = nullptr;
|
||||
*
|
||||
* NOTE: This is needed for Voxengo VST2 plugins in Renoise. When
|
||||
* `effSetChunk()` is called from the GUI thread, Voxengo VST2 plugins
|
||||
* will (wrongly) call `audioMasterUpdateDisplay()` while handling that
|
||||
* call. Renoise then calls `effGetProgram()` while handling that which
|
||||
* will (wrongly) call `audioMasterUpdateDisplay()` during that
|
||||
* call. Renoise then calls `effGetProgram()` during that which
|
||||
* shouldn't cause any issues, but the Voxengo plugins try to lock
|
||||
* recursive mutexes on both functions so `effGetProgram()` _has_ to be
|
||||
* called on the same thread that is currently calling
|
||||
@@ -89,7 +89,7 @@ static const std::unordered_set<int> safe_mutually_recursive_requests{
|
||||
* involve GUI operations.
|
||||
*
|
||||
* NOTE: `effMainsChanged` is the odd one here. EZdrummer interacts with the
|
||||
* Win32 message loop while handling this function. If we don't execute
|
||||
* Win32 message loop during this function. If we don't execute
|
||||
* this from the main GUI thread, then EZdrummer won't produce any sound.
|
||||
* NOTE: `effSetChunk` and `effGetChunk` should be callable from any thread, but
|
||||
* Algonaut Atlas doesn't restore chunk data unless `effSetChunk` is run
|
||||
|
||||
@@ -1826,7 +1826,7 @@ size_t Vst3Bridge::register_object_instance(
|
||||
|
||||
void Vst3Bridge::unregister_object_instance(size_t instance_id) {
|
||||
// Tear the dedicated audio processing socket down again if we
|
||||
// created one while handling `Vst3PluginProxy::Construct`
|
||||
// created one during `Vst3PluginProxy::Construct`
|
||||
if (const auto& [instance, _] = get_instance(instance_id);
|
||||
instance.interfaces.audio_processor || instance.interfaces.component) {
|
||||
sockets_.remove_audio_processor(instance_id);
|
||||
|
||||
@@ -147,7 +147,7 @@ struct Vst3PluginInstance {
|
||||
* If the host passes an `IPlugFrame` object during `IPlugView::setFrame()`,
|
||||
* then we'll store a proxy object here and then pass it to
|
||||
* `plug_view->setFrame()`. Will be initialized with a null pointer until
|
||||
* used. When we destroy `plug_view` while handling
|
||||
* used. When we destroy `plug_view` during
|
||||
* `Vst3PlugViewProxy::Destruct`, we'll also destroy (our pointer of) this
|
||||
* proxy object.
|
||||
*/
|
||||
|
||||
Reference in New Issue
Block a user